dotcloud/docker

View on GitHub
daemon/logger/loggerutils/file_windows.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function volumeName has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
Open

func volumeName(path string) (v string) {
    if len(path) < 2 {
        return ""
    }
    // with drive letter
Severity: Minor
Found in daemon/logger/loggerutils/file_windows.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

    if path[1] == ':' &&
        ('0' <= c && c <= '9' || 'a' <= c && c <= 'z' ||
            'A' <= c && c <= 'Z') {
Severity: Major
Found in daemon/logger/loggerutils/file_windows.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        if path[n] == '.' {
                            break
                        }
    Severity: Major
    Found in daemon/logger/loggerutils/file_windows.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          for ; n < l; n++ {
                              if os.IsPathSeparator(path[n]) {
                                  break
                              }
                          }
      Severity: Major
      Found in daemon/logger/loggerutils/file_windows.go - About 45 mins to fix

        Function unlink has 5 return statements (exceeds 4 allowed).
        Open

        func unlink(name string) error {
            // Rename the file before deleting it so that the original name is freed
            // up to be reused, even while there are still open FILE_SHARE_DELETE
            // file handles. Emulate POSIX unlink() semantics, essentially.
            name, err := filepath.Abs(name)
        Severity: Major
        Found in daemon/logger/loggerutils/file_windows.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status