Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/logger/loggerutils/follow.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method follow.Do has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func (fl *follow) Do(ctx context.Context, f *os.File, read logPos) {
    fl.log = log.G(ctx).WithFields(log.Fields{
        "module": "logger",
        "file":   f.Name(),
    })
Severity: Minor
Found in daemon/logger/loggerutils/follow.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method follow.Do has 52 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (fl *follow) Do(ctx context.Context, f *os.File, read logPos) {
    fl.log = log.G(ctx).WithFields(log.Fields{
        "module": "logger",
        "file":   f.Name(),
    })
Severity: Minor
Found in daemon/logger/loggerutils/follow.go - About 1 hr to fix

    Method follow.nextPos has 5 return statements (exceeds 4 allowed).
    Open

    func (fl *follow) nextPos(ctx context.Context, current logPos) (next logPos, ok bool) {
    var st logReadState
    select {
    case <-ctx.Done():
        return current, false
    Severity: Major
    Found in daemon/logger/loggerutils/follow.go - About 35 mins to fix

      Method follow.Do has 5 return statements (exceeds 4 allowed).
      Open

      func (fl *follow) Do(ctx context.Context, f *os.File, read logPos) {
    fl.log = log.G(ctx).WithFields(log.Fields{
        "module": "logger",
        "file":   f.Name(),
    })
      Severity: Major
      Found in daemon/logger/loggerutils/follow.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status