Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/logs.go

Summary

Maintainability
C
1 day
Test Coverage

Method Daemon.ContainerLogs has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
Open

func (daemon *Daemon) ContainerLogs(ctx context.Context, containerName string, config *containertypes.LogsOptions) (messages <-chan *backend.LogMessage, isTTY bool, retErr error) {
    ctx, span := tracing.StartSpan(ctx, "daemon.ContainerLogs")
    defer func() {
        span.SetStatus(retErr)
        span.End()
Severity: Minor
Found in daemon/logs.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Daemon.ContainerLogs has 106 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) ContainerLogs(ctx context.Context, containerName string, config *containertypes.LogsOptions) (messages <-chan *backend.LogMessage, isTTY bool, retErr error) {
    ctx, span := tracing.StartSpan(ctx, "daemon.ContainerLogs")
    defer func() {
        span.SetStatus(retErr)
        span.End()
Severity: Major
Found in daemon/logs.go - About 3 hrs to fix

    Method Daemon.ContainerLogs has 13 return statements (exceeds 4 allowed).
    Open

    func (daemon *Daemon) ContainerLogs(ctx context.Context, containerName string, config *containertypes.LogsOptions) (messages <-chan *backend.LogMessage, isTTY bool, retErr error) {
    ctx, span := tracing.StartSpan(ctx, "daemon.ContainerLogs")
    defer func() {
        span.SetStatus(retErr)
        span.End()
    Severity: Major
    Found in daemon/logs.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status