Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/network.go

Summary

Maintainability
F
5 days
Test Coverage

File network.go has 888 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package daemon // import "github.com/docker/docker/daemon"

import (
    "context"
    "errors"
Severity: Major
Found in daemon/network.go - About 1 day to fix

    Daemon has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) NetworkControllerEnabled() bool {
    return daemon.netController != nil
}
    Severity: Minor
    Found in daemon/network.go - About 3 hrs to fix

      Method Daemon.createNetwork has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
      Open

      func (daemon *Daemon) createNetwork(cfg *config.Config, create networktypes.CreateRequest, id string, agent bool) (*networktypes.CreateResponse, error) {
    if network.IsPredefined(create.Name) {
        return nil, PredefinedNetworkError(create.Name)
    }
      Severity: Minor
      Found in daemon/network.go - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Daemon.createNetwork has 103 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (daemon *Daemon) createNetwork(cfg *config.Config, create networktypes.CreateRequest, id string, agent bool) (*networktypes.CreateResponse, error) {
    if network.IsPredefined(create.Name) {
        return nil, PredefinedNetworkError(create.Name)
    }
      Severity: Major
      Found in daemon/network.go - About 3 hrs to fix

        Function buildCreateEndpointOptions has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
        Open

        func buildCreateEndpointOptions(c *container.Container, n *libnetwork.Network, epConfig *network.EndpointSettings, sb *libnetwork.Sandbox, daemonDNS []string) ([]libnetwork.EndpointOption, error) {
    var createOptions []libnetwork.EndpointOption
    genericOptions := make(options.Generic)

    nwName := n.Name()
        Severity: Minor
        Found in daemon/network.go - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildCreateEndpointOptions has 69 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func buildCreateEndpointOptions(c *container.Container, n *libnetwork.Network, epConfig *network.EndpointSettings, sb *libnetwork.Sandbox, daemonDNS []string) ([]libnetwork.EndpointOption, error) {
    var createOptions []libnetwork.EndpointOption
    genericOptions := make(options.Generic)

    nwName := n.Name()
        Severity: Minor
        Found in daemon/network.go - About 1 hr to fix

          Function buildIPAMResources has 59 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func buildIPAMResources(nw *libnetwork.Network) networktypes.IPAM {
    var ipamConfig []networktypes.IPAMConfig

    ipamDriver, ipamOptions, ipv4Conf, ipv6Conf := nw.IpamConfig()
          Severity: Minor
          Found in daemon/network.go - About 1 hr to fix

            Function buildPortsRelatedCreateEndpointOptions has 59 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func buildPortsRelatedCreateEndpointOptions(c *container.Container, n *libnetwork.Network, sb *libnetwork.Sandbox) ([]libnetwork.EndpointOption, error) {
    // Port-mapping rules belong to the container & applicable only to non-internal networks.
    //
    // TODO(thaJeztah): Look if we can provide a more minimal function for getPortMapInfo, as it does a lot, and we only need the "length".
    if n.Internal() || len(getPortMapInfo(sb)) > 0 {
            Severity: Minor
            Found in daemon/network.go - About 1 hr to fix

              Function buildIPAMResources has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
              Open

              func buildIPAMResources(nw *libnetwork.Network) networktypes.IPAM {
    var ipamConfig []networktypes.IPAMConfig

    ipamDriver, ipamOptions, ipv4Conf, ipv6Conf := nw.IpamConfig()
              Severity: Minor
              Found in daemon/network.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Daemon.createNetwork has 10 return statements (exceeds 4 allowed).
              Open

              func (daemon *Daemon) createNetwork(cfg *config.Config, create networktypes.CreateRequest, id string, agent bool) (*networktypes.CreateResponse, error) {
    if network.IsPredefined(create.Name) {
        return nil, PredefinedNetworkError(create.Name)
    }
              Severity: Major
              Found in daemon/network.go - About 1 hr to fix

                Function buildCreateEndpointOptions has 6 return statements (exceeds 4 allowed).
                Open

                func buildCreateEndpointOptions(c *container.Container, n *libnetwork.Network, epConfig *network.EndpointSettings, sb *libnetwork.Sandbox, daemonDNS []string) ([]libnetwork.EndpointOption, error) {
    var createOptions []libnetwork.EndpointOption
    genericOptions := make(options.Generic)

    nwName := n.Name()
                Severity: Major
                Found in daemon/network.go - About 40 mins to fix

                  Function getEndpointPortMapInfo has 6 return statements (exceeds 4 allowed).
                  Open

                  func getEndpointPortMapInfo(ep *libnetwork.Endpoint) (nat.PortMap, error) {
    pm := nat.PortMap{}
    driverInfo, err := ep.DriverInfo()
    if err != nil {
        return pm, err
                  Severity: Major
                  Found in daemon/network.go - About 40 mins to fix

                    Function buildCreateEndpointOptions has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func buildCreateEndpointOptions(c *container.Container, n *libnetwork.Network, epConfig *network.EndpointSettings, sb *libnetwork.Sandbox, daemonDNS []string) ([]libnetwork.EndpointOption, error) {
                    Severity: Minor
                    Found in daemon/network.go - About 35 mins to fix

                      Method Daemon.deleteNetwork has 5 return statements (exceeds 4 allowed).
                      Open

                      func (daemon *Daemon) deleteNetwork(nw *libnetwork.Network, dynamic bool) error {
    if network.IsPredefined(nw.Name()) && !dynamic {
        err := fmt.Errorf("%s is a pre-defined network and cannot be removed", nw.Name())
        return errdefs.Forbidden(err)
    }
                      Severity: Major
                      Found in daemon/network.go - About 35 mins to fix

                        Function getEndpointPortMapInfo has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func getEndpointPortMapInfo(ep *libnetwork.Endpoint) (nat.PortMap, error) {
    pm := nat.PortMap{}
    driverInfo, err := ep.DriverInfo()
    if err != nil {
        return pm, err
                        Severity: Minor
                        Found in daemon/network.go - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function buildEndpointInfo has 5 return statements (exceeds 4 allowed).
                        Open

                        func buildEndpointInfo(networkSettings *network.Settings, n *libnetwork.Network, ep *libnetwork.Endpoint) error {
    if ep == nil {
        return errors.New("endpoint cannot be nil")
    }
                        Severity: Major
                        Found in daemon/network.go - About 35 mins to fix

                          Function buildPortsRelatedCreateEndpointOptions has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                          Open

                          func buildPortsRelatedCreateEndpointOptions(c *container.Container, n *libnetwork.Network, sb *libnetwork.Sandbox) ([]libnetwork.EndpointOption, error) {
    // Port-mapping rules belong to the container & applicable only to non-internal networks.
    //
    // TODO(thaJeztah): Look if we can provide a more minimal function for getPortMapInfo, as it does a lot, and we only need the "length".
    if n.Internal() || len(getPortMapInfo(sb)) > 0 {
                          Severity: Minor
                          Found in daemon/network.go - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              for _, port := range ports {
        portProto := lntypes.ParseProtocol(port.Proto())
        portNum := uint16(port.Int())
        exposedPorts = append(exposedPorts, lntypes.TransportPort{
            Proto: portProto,
                          Severity: Major
                          Found in daemon/network.go and 1 other location - About 3 hrs to fix
                          daemon/container_operations.go on lines 124..156

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 291.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              if create.EnableIPv6 != nil {
        enableIPv6 = *create.EnableIPv6
    } else if v, ok := networkOptions[netlabel.EnableIPv6]; ok {
        var err error
        if enableIPv6, err = strconv.ParseBool(v); err != nil {
                          Severity: Minor
                          Found in daemon/network.go and 1 other location - About 35 mins to fix
                          daemon/network.go on lines 320..327

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 106.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              if c.HostConfig.PortBindings != nil {
        for p, b := range c.HostConfig.PortBindings {
            bindings[p] = []nat.PortBinding{}
            for _, bb := range b {
                bindings[p] = append(bindings[p], nat.PortBinding{
                          Severity: Minor
                          Found in daemon/network.go and 1 other location - About 35 mins to fix
                          daemon/container_operations.go on lines 101..111

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 106.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              if create.EnableIPv4 != nil {
        enableIPv4 = *create.EnableIPv4
    } else if v, ok := networkOptions[netlabel.EnableIPv4]; ok {
        var err error
        if enableIPv4, err = strconv.ParseBool(v); err != nil {
                          Severity: Minor
                          Found in daemon/network.go and 1 other location - About 35 mins to fix
                          daemon/network.go on lines 335..342

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 106.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status