Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/oci_linux.go

Summary

Maintainability
F
1 wk
Test Coverage

Function withMounts has a Cognitive Complexity of 165 (exceeds 20 allowed). Consider refactoring.
Open

func withMounts(daemon *Daemon, daemonCfg *configStore, c *container.Container, mounts []container.Mount) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) (err error) {
        sortMounts(mounts)

        userMounts := make(map[string]struct{})
Severity: Minor
Found in daemon/oci_linux.go - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File oci_linux.go has 904 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package daemon // import "github.com/docker/docker/daemon"

import (
    "context"
    "fmt"
Severity: Major
Found in daemon/oci_linux.go - About 1 day to fix

    Function withMounts has 151 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func withMounts(daemon *Daemon, daemonCfg *configStore, c *container.Container, mounts []container.Mount) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) (err error) {
        sortMounts(mounts)

        userMounts := make(map[string]struct{})
    Severity: Major
    Found in daemon/oci_linux.go - About 5 hrs to fix

      Function WithNamespaces has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
      Open

      func WithNamespaces(daemon *Daemon, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        userNS := false
        // user
        if c.HostConfig.UsernsMode.IsPrivate() {
      Severity: Minor
      Found in daemon/oci_linux.go - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function WithDevices has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
      Open

      func WithDevices(daemon *Daemon, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        // Build lists of devices allowed and created within the container.
        var devs []specs.LinuxDevice
        devPermissions := s.Linux.Resources.Devices
      Severity: Minor
      Found in daemon/oci_linux.go - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function WithNamespaces has 111 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func WithNamespaces(daemon *Daemon, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        userNS := false
        // user
        if c.HostConfig.UsernsMode.IsPrivate() {
      Severity: Major
      Found in daemon/oci_linux.go - About 3 hrs to fix

        Function withCommonOptions has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
        Open

        func withCommonOptions(daemon *Daemon, daemonCfg *dconfig.Config, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        if c.BaseFS == "" {
            return errors.New("populateCommonSpec: BaseFS of container " + c.ID + " is unexpectedly empty")
        }
        Severity: Minor
        Found in daemon/oci_linux.go - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function withCgroups has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

        func withCgroups(daemon *Daemon, daemonCfg *dconfig.Config, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        var cgroupsPath string
        scopePrefix := "docker"
        parent := "/docker"
        Severity: Minor
        Found in daemon/oci_linux.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function WithDevices has 59 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func WithDevices(daemon *Daemon, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        // Build lists of devices allowed and created within the container.
        var devs []specs.LinuxDevice
        devPermissions := s.Linux.Resources.Devices
        Severity: Minor
        Found in daemon/oci_linux.go - About 1 hr to fix

          Function withCommonOptions has 55 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func withCommonOptions(daemon *Daemon, daemonCfg *dconfig.Config, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        if c.BaseFS == "" {
            return errors.New("populateCommonSpec: BaseFS of container " + c.ID + " is unexpectedly empty")
        }
          Severity: Minor
          Found in daemon/oci_linux.go - About 1 hr to fix

            Function withCgroups has 54 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func withCgroups(daemon *Daemon, daemonCfg *dconfig.Config, c *container.Container) coci.SpecOpts {
    return func(ctx context.Context, _ coci.Client, _ *containers.Container, s *coci.Spec) error {
        var cgroupsPath string
        scopePrefix := "docker"
        parent := "/docker"
            Severity: Minor
            Found in daemon/oci_linux.go - About 1 hr to fix

              Function getUser has 5 return statements (exceeds 4 allowed).
              Open

              func getUser(c *container.Container, username string) (specs.User, error) {
    var usr specs.User
    passwdPath, err := resourcePath(c, user.GetPasswdPath)
    if err != nil {
        return usr, err
              Severity: Major
              Found in daemon/oci_linux.go - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        case pidMode.IsContainer():
            pc, err := daemon.getPIDContainer(pidMode.Container())
            if err != nil {
                return errors.Wrap(err, "failed to join PID namespace")
            }
                Severity: Major
                Found in daemon/oci_linux.go and 1 other location - About 1 hr to fix
                daemon/oci_linux.go on lines 308..325

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 154.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        case ipcMode.IsContainer():
            ic, err := daemon.getIPCContainer(ipcMode.Container())
            if err != nil {
                return errors.Wrap(err, "failed to join IPC namespace")
            }
                Severity: Major
                Found in daemon/oci_linux.go and 1 other location - About 1 hr to fix
                daemon/oci_linux.go on lines 344..361

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 154.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status