Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/prune.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Daemon.ContainersPrune has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func (daemon *Daemon) ContainersPrune(ctx context.Context, pruneFilters filters.Args) (*container.PruneReport, error) {
    if !atomic.CompareAndSwapInt32(&daemon.pruneRunning, 0, 1) {
        return nil, errPruneRunning
    }
    defer atomic.StoreInt32(&daemon.pruneRunning, 0)
Severity: Minor
Found in daemon/prune.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Daemon.localNetworksPrune has 9 return statements (exceeds 4 allowed).
Open

func (daemon *Daemon) localNetworksPrune(ctx context.Context, pruneFilters filters.Args) *network.PruneReport {
    rep := &network.PruneReport{}

    until, _ := getUntilFromPruneFilters(pruneFilters)
Severity: Major
Found in daemon/prune.go - About 55 mins to fix

    Method Daemon.clusterNetworksPrune has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) clusterNetworksPrune(ctx context.Context, pruneFilters filters.Args) (*network.PruneReport, error) {
    rep := &network.PruneReport{}

    until, _ := getUntilFromPruneFilters(pruneFilters)
    Severity: Minor
    Found in daemon/prune.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Daemon.ContainersPrune has 6 return statements (exceeds 4 allowed).
    Open

    func (daemon *Daemon) ContainersPrune(ctx context.Context, pruneFilters filters.Args) (*container.PruneReport, error) {
    if !atomic.CompareAndSwapInt32(&daemon.pruneRunning, 0, 1) {
        return nil, errPruneRunning
    }
    defer atomic.StoreInt32(&daemon.pruneRunning, 0)
    Severity: Major
    Found in daemon/prune.go - About 40 mins to fix

      Function getUntilFromPruneFilters has 5 return statements (exceeds 4 allowed).
      Open

      func getUntilFromPruneFilters(pruneFilters filters.Args) (time.Time, error) {
    until := time.Time{}
    if !pruneFilters.Contains("until") {
        return until, nil
    }
      Severity: Major
      Found in daemon/prune.go - About 35 mins to fix

        Method Daemon.NetworksPrune has 5 return statements (exceeds 4 allowed).
        Open

        func (daemon *Daemon) NetworksPrune(ctx context.Context, pruneFilters filters.Args) (*network.PruneReport, error) {
    if !atomic.CompareAndSwapInt32(&daemon.pruneRunning, 0, 1) {
        return nil, errPruneRunning
    }
    defer atomic.StoreInt32(&daemon.pruneRunning, 0)
        Severity: Major
        Found in daemon/prune.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status