Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/start.go

Summary

Maintainability
C
1 day
Test Coverage

Method Daemon.containerStart has a Cognitive Complexity of 51 (exceeds 20 allowed). Consider refactoring.
Open

func (daemon *Daemon) containerStart(ctx context.Context, daemonCfg *configStore, container *container.Container, checkpoint string, checkpointDir string, resetRestartManager bool) (retErr error) {
    ctx, span := otel.Tracer("").Start(ctx, "daemon.containerStart", trace.WithAttributes(
        attribute.String("container.ID", container.ID),
        attribute.String("container.Name", container.Name)))
    defer span.End()
Severity: Minor
Found in daemon/start.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Daemon.containerStart has 130 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) containerStart(ctx context.Context, daemonCfg *configStore, container *container.Container, checkpoint string, checkpointDir string, resetRestartManager bool) (retErr error) {
    ctx, span := otel.Tracer("").Start(ctx, "daemon.containerStart", trace.WithAttributes(
        attribute.String("container.ID", container.ID),
        attribute.String("container.Name", container.Name)))
    defer span.End()
Severity: Major
Found in daemon/start.go - About 4 hrs to fix

    Method Daemon.containerStart has 19 return statements (exceeds 4 allowed).
    Open

    func (daemon *Daemon) containerStart(ctx context.Context, daemonCfg *configStore, container *container.Container, checkpoint string, checkpointDir string, resetRestartManager bool) (retErr error) {
    ctx, span := otel.Tracer("").Start(ctx, "daemon.containerStart", trace.WithAttributes(
        attribute.String("container.ID", container.ID),
        attribute.String("container.Name", container.Name)))
    defer span.End()
    Severity: Major
    Found in daemon/start.go - About 1 hr to fix

      Method Daemon.containerStart has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (daemon *Daemon) containerStart(ctx context.Context, daemonCfg *configStore, container *container.Container, checkpoint string, checkpointDir string, resetRestartManager bool) (retErr error) {
      Severity: Minor
      Found in daemon/start.go - About 45 mins to fix

        Method Daemon.ContainerStart has 5 return statements (exceeds 4 allowed).
        Open

        func (daemon *Daemon) ContainerStart(ctx context.Context, name string, checkpoint string, checkpointDir string) error {
    daemonCfg := daemon.config()
    if checkpoint != "" && !daemonCfg.Experimental {
        return errdefs.InvalidParameter(errors.New("checkpoint is only supported in experimental mode"))
    }
        Severity: Major
        Found in daemon/start.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status