Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/stats_unix.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Daemon.statsV2 has 88 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) statsV2(s *containertypes.StatsResponse, stats *statsV2.Metrics) (*containertypes.StatsResponse, error) {
    if stats.Io != nil {
        var isbr []containertypes.BlkioStatEntry
        for _, re := range stats.Io.Usage {
            isbr = append(isbr,
Severity: Major
Found in daemon/stats_unix.go - About 2 hrs to fix

    Method Daemon.statsV1 has 86 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) statsV1(s *containertypes.StatsResponse, stats *statsV1.Metrics) (*containertypes.StatsResponse, error) {
    if stats.Blkio != nil {
        s.BlkioStats = containertypes.BlkioStats{
            IoServiceBytesRecursive: copyBlkioEntry(stats.Blkio.IoServiceBytesRecursive),
            IoServicedRecursive:     copyBlkioEntry(stats.Blkio.IoServicedRecursive),
    Severity: Major
    Found in daemon/stats_unix.go - About 2 hrs to fix

      Function getSystemCPUUsage has 5 return statements (exceeds 4 allowed).
      Open

      func getSystemCPUUsage() (cpuUsage uint64, cpuNum uint32, err error) {
    f, err := os.Open("/proc/stat")
    if err != nil {
        return 0, 0, err
    }
      Severity: Major
      Found in daemon/stats_unix.go - About 35 mins to fix

        Function getSystemCPUUsage has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func getSystemCPUUsage() (cpuUsage uint64, cpuNum uint32, err error) {
    f, err := os.Open("/proc/stat")
    if err != nil {
        return 0, 0, err
    }
        Severity: Minor
        Found in daemon/stats_unix.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status