Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/volumes.go

Summary

Maintainability
D
2 days
Test Coverage

Method Daemon.registerMountPoints has a Cognitive Complexity of 104 (exceeds 20 allowed). Consider refactoring.
Open

func (daemon *Daemon) registerMountPoints(container *container.Container, hostConfig *containertypes.HostConfig, defaultReadOnlyNonRecursive bool) (retErr error) {
    binds := map[string]bool{}
    mountPoints := map[string]*volumemounts.MountPoint{}
    parser := volumemounts.NewParser()
Severity: Minor
Found in daemon/volumes.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Daemon.registerMountPoints has 166 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) registerMountPoints(container *container.Container, hostConfig *containertypes.HostConfig, defaultReadOnlyNonRecursive bool) (retErr error) {
    binds := map[string]bool{}
    mountPoints := map[string]*volumemounts.MountPoint{}
    parser := volumemounts.NewParser()
Severity: Major
Found in daemon/volumes.go - About 5 hrs to fix

    Method Daemon.registerMountPoints has 12 return statements (exceeds 4 allowed).
    Open

    func (daemon *Daemon) registerMountPoints(container *container.Container, hostConfig *containertypes.HostConfig, defaultReadOnlyNonRecursive bool) (retErr error) {
    binds := map[string]bool{}
    mountPoints := map[string]*volumemounts.MountPoint{}
    parser := volumemounts.NewParser()
    Severity: Major
    Found in daemon/volumes.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status