Sign upLogin

dotcloud/docker

View on GitHub
Star
image/cache/cache.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method ImageCache.GetCache has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func (ic *ImageCache) GetCache(parentID string, cfg *containertypes.Config, platform ocispec.Platform) (string, error) {
    imgID, err := ic.localImageCache.GetCache(parentID, cfg, platform)
    if err != nil {
        return "", err
    }
Severity: Minor
Found in image/cache/cache.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageCache.GetCache has 8 return statements (exceeds 4 allowed).
Open

func (ic *ImageCache) GetCache(parentID string, cfg *containertypes.Config, platform ocispec.Platform) (string, error) {
    imgID, err := ic.localImageCache.GetCache(parentID, cfg, platform)
    if err != nil {
        return "", err
    }
Severity: Major
Found in image/cache/cache.go - About 50 mins to fix

    Function isValidParent has 7 return statements (exceeds 4 allowed).
    Open

    func isValidParent(img, parent *image.Image) bool {
    if len(img.History) == 0 {
        return false
    }
    if parent == nil || len(parent.History) == 0 && len(parent.RootFS.DiffIDs) == 0 {
    Severity: Major
    Found in image/cache/cache.go - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status