Sign upLogin

dotcloud/docker

View on GitHub
Star
image/store.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method store.restore has 8 return statements (exceeds 4 allowed).
Open

func (is *store) restore() error {
    // As the code below is run when restoring all images (which can be "many"),
    // constructing the "log.G(ctx).WithFields" is deliberately not "DRY", as the
    // logger is only used for error-cases, and we don't want to do allocations
    // if we don't need it. The "f" type alias is here is just for convenience,
Severity: Major
Found in image/store.go - About 50 mins to fix

    Method store.Create has 8 return statements (exceeds 4 allowed).
    Open

    func (is *store) Create(config []byte) (ID, error) {
    var img *Image
    img, err := NewFromJSON(config)
    if err != nil {
        return "", err
    Severity: Major
    Found in image/store.go - About 50 mins to fix

      Method store.restore has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Open

      func (is *store) restore() error {
    // As the code below is run when restoring all images (which can be "many"),
    // constructing the "log.G(ctx).WithFields" is deliberately not "DRY", as the
    // logger is only used for error-cases, and we don't want to do allocations
    // if we don't need it. The "f" type alias is here is just for convenience,
      Severity: Minor
      Found in image/store.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status