Sign upLogin

dotcloud/docker

View on GitHub
Star
internal/mounttree/switchroot_linux.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function SwitchRoot has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func SwitchRoot(path string) error {
    if mounted, _ := mountinfo.Mounted(path); !mounted {
        if err := mount.Mount(path, path, "bind", "rbind,rw"); err != nil {
            return realChroot(path)
        }
Severity: Minor
Found in internal/mounttree/switchroot_linux.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SwitchRoot has 9 return statements (exceeds 4 allowed).
Open

func SwitchRoot(path string) error {
    if mounted, _ := mountinfo.Mounted(path); !mounted {
        if err := mount.Mount(path, path, "bind", "rbind,rw"); err != nil {
            return realChroot(path)
        }
Severity: Major
Found in internal/mounttree/switchroot_linux.go - About 55 mins to fix

    There are no issues that match your filters.

    Category
    Status