Sign upLogin

dotcloud/docker

View on GitHub
Star
internal/rootless/specconv/specconv_linux.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function toRootless has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func toRootless(spec *specs.Spec, v2Controllers []string, currentOOMScoreAdj int) error {
    if len(v2Controllers) == 0 {
        if spec.Linux != nil {
            // Remove cgroup settings.
            spec.Linux.Resources = nil
Severity: Minor
Found in internal/rootless/specconv/specconv_linux.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toRootless has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func toRootless(spec *specs.Spec, v2Controllers []string, currentOOMScoreAdj int) error {
    if len(v2Controllers) == 0 {
        if spec.Linux != nil {
            // Remove cgroup settings.
            spec.Linux.Resources = nil
Severity: Minor
Found in internal/rootless/specconv/specconv_linux.go - About 1 hr to fix

    Function isHostNS has 7 return statements (exceeds 4 allowed).
    Open

    func isHostNS(spec *specs.Spec, nsType specs.LinuxNamespaceType) (bool, error) {
    if strings.Contains(string(nsType), string(os.PathSeparator)) {
        return false, fmt.Errorf("unexpected namespace type %q", nsType)
    }
    if spec.Linux == nil {
    Severity: Major
    Found in internal/rootless/specconv/specconv_linux.go - About 45 mins to fix

      Function toRootless has 5 return statements (exceeds 4 allowed).
      Open

      func toRootless(spec *specs.Spec, v2Controllers []string, currentOOMScoreAdj int) error {
    if len(v2Controllers) == 0 {
        if spec.Linux != nil {
            // Remove cgroup settings.
            spec.Linux.Resources = nil
      Severity: Major
      Found in internal/rootless/specconv/specconv_linux.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status