Sign upLogin

dotcloud/docker

View on GitHub
Star
internal/safepath/k8s_safeopen_linux.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function kubernetesSafeOpen has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func kubernetesSafeOpen(base, subpath string) (int, error) {
    // syscall.Openat flags used to traverse directories not following symlinks
    const nofollowFlags = unix.O_RDONLY | unix.O_NOFOLLOW
    // flags for getting file descriptor without following the symlink
    const openFDFlags = unix.O_NOFOLLOW | unix.O_PATH
Severity: Minor
Found in internal/safepath/k8s_safeopen_linux.go - About 1 hr to fix

    Function kubernetesSafeOpen has 7 return statements (exceeds 4 allowed).
    Open

    func kubernetesSafeOpen(base, subpath string) (int, error) {
    // syscall.Openat flags used to traverse directories not following symlinks
    const nofollowFlags = unix.O_RDONLY | unix.O_NOFOLLOW
    // flags for getting file descriptor without following the symlink
    const openFDFlags = unix.O_NOFOLLOW | unix.O_PATH
    Severity: Major
    Found in internal/safepath/k8s_safeopen_linux.go - About 45 mins to fix

      Function kubernetesSafeOpen has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func kubernetesSafeOpen(base, subpath string) (int, error) {
    // syscall.Openat flags used to traverse directories not following symlinks
    const nofollowFlags = unix.O_RDONLY | unix.O_NOFOLLOW
    // flags for getting file descriptor without following the symlink
    const openFDFlags = unix.O_NOFOLLOW | unix.O_PATH
      Severity: Minor
      Found in internal/safepath/k8s_safeopen_linux.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status