Sign upLogin

dotcloud/docker

View on GitHub
Star
libcontainerd/local/local_windows.go

Summary

Maintainability
F
5 days
Test Coverage

File local_windows.go has 912 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package local // import "github.com/docker/docker/libcontainerd/local"

// This package contains the legacy in-proc calls in HCS using the v1 schema
// for Windows runtime purposes.
Severity: Major
Found in libcontainerd/local/local_windows.go - About 1 day to fix

    Method client.createWindows has a Cognitive Complexity of 65 (exceeds 20 allowed). Consider refactoring.
    Open

    func (c *client) createWindows(id string, spec *specs.Spec, runtimeOptions interface{}) (*container, error) {
    logger := c.logger.WithField("container", id)
    configuration := &hcsshim.ContainerConfig{
        SystemType:              "Container",
        Name:                    id,
    Severity: Minor
    Found in libcontainerd/local/local_windows.go - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method client.createWindows has 147 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (c *client) createWindows(id string, spec *specs.Spec, runtimeOptions interface{}) (*container, error) {
    logger := c.logger.WithField("container", id)
    configuration := &hcsshim.ContainerConfig{
        SystemType:              "Container",
        Name:                    id,
    Severity: Major
    Found in libcontainerd/local/local_windows.go - About 4 hrs to fix

      Method task.Exec has 95 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (t *task) Exec(ctx context.Context, processID string, spec *specs.Process, withStdin bool, attachStdio libcontainerdtypes.StdioCallback) (_ libcontainerdtypes.Process, retErr error) {
    hcsContainer, err := t.getHCSContainer()
    if err != nil {
        return nil, err
    }
      Severity: Major
      Found in libcontainerd/local/local_windows.go - About 2 hrs to fix

        Method container.NewTask has 94 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (ctr *container) NewTask(_ context.Context, _ string, withStdin bool, attachStdio libcontainerdtypes.StdioCallback) (_ libcontainerdtypes.Task, retErr error) {
    ctr.mu.Lock()
    defer ctr.mu.Unlock()

    switch {
        Severity: Major
        Found in libcontainerd/local/local_windows.go - About 2 hrs to fix

          Method client.createWindows has 14 return statements (exceeds 4 allowed).
          Open

          func (c *client) createWindows(id string, spec *specs.Spec, runtimeOptions interface{}) (*container, error) {
    logger := c.logger.WithField("container", id)
    configuration := &hcsshim.ContainerConfig{
        SystemType:              "Container",
        Name:                    id,
          Severity: Major
          Found in libcontainerd/local/local_windows.go - About 1 hr to fix

            Method task.Exec has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
            Open

            func (t *task) Exec(ctx context.Context, processID string, spec *specs.Process, withStdin bool, attachStdio libcontainerdtypes.StdioCallback) (_ libcontainerdtypes.Process, retErr error) {
    hcsContainer, err := t.getHCSContainer()
    if err != nil {
        return nil, err
    }
            Severity: Minor
            Found in libcontainerd/local/local_windows.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process.reap has 52 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (p *process) reap() {
    logger := p.ctr.client.logger.WithFields(log.Fields{
        "container": p.ctr.id,
        "process":   p.id,
    })
            Severity: Minor
            Found in libcontainerd/local/local_windows.go - About 1 hr to fix

              Method client.NewContainer has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (c *client) NewContainer(_ context.Context, id string, spec *specs.Spec, shim string, runtimeOptions interface{}, opts ...containerd.NewContainerOpts) (libcontainerdtypes.Container, error) {
              Severity: Minor
              Found in libcontainerd/local/local_windows.go - About 45 mins to fix

                Method task.Exec has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func (t *task) Exec(ctx context.Context, processID string, spec *specs.Process, withStdin bool, attachStdio libcontainerdtypes.StdioCallback) (_ libcontainerdtypes.Process, retErr error) {
                Severity: Minor
                Found in libcontainerd/local/local_windows.go - About 35 mins to fix

                  Method container.NewTask has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func (ctr *container) NewTask(_ context.Context, _ string, withStdin bool, attachStdio libcontainerdtypes.StdioCallback) (_ libcontainerdtypes.Task, retErr error) {
    ctr.mu.Lock()
    defer ctr.mu.Unlock()

    switch {
                  Severity: Minor
                  Found in libcontainerd/local/local_windows.go - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method task.Resume has 5 return statements (exceeds 4 allowed).
                  Open

                  func (t *task) Resume(ctx context.Context) error {
    if t.ctr.ociSpec.Windows.HyperV == nil {
        return errors.New("cannot resume Windows Server Containers")
    }
                  Severity: Major
                  Found in libcontainerd/local/local_windows.go - About 35 mins to fix

                    Method task.Exec has 5 return statements (exceeds 4 allowed).
                    Open

                    func (t *task) Exec(ctx context.Context, processID string, spec *specs.Process, withStdin bool, attachStdio libcontainerdtypes.StdioCallback) (_ libcontainerdtypes.Process, retErr error) {
    hcsContainer, err := t.getHCSContainer()
    if err != nil {
        return nil, err
    }
                    Severity: Major
                    Found in libcontainerd/local/local_windows.go - About 35 mins to fix

                      Method task.Pause has 5 return statements (exceeds 4 allowed).
                      Open

                      func (t *task) Pause(_ context.Context) error {
    if t.ctr.ociSpec.Windows.HyperV == nil {
        return cerrdefs.ErrNotImplemented
    }
                      Severity: Major
                      Found in libcontainerd/local/local_windows.go - About 35 mins to fix

                        Method client.extractResourcesFromSpec has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (c *client) extractResourcesFromSpec(spec *specs.Spec, configuration *hcsshim.ContainerConfig) {
    if spec.Windows.Resources != nil {
        if spec.Windows.Resources.CPU != nil {
            if spec.Windows.Resources.CPU.Count != nil {
                // This check is being done here rather than in adaptContainerSettings
                        Severity: Minor
                        Found in libcontainerd/local/local_windows.go - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            t.ctr.client.eventQ.Append(t.ctr.id, func() {
        err := t.ctr.client.backend.ProcessEvent(t.ctr.id, libcontainerdtypes.EventResumed, libcontainerdtypes.EventInfo{
            ContainerID: t.ctr.id,
            ProcessID:   t.id,
        })
                        Severity: Major
                        Found in libcontainerd/local/local_windows.go and 1 other location - About 2 hrs to fix
                        libcontainerd/local/local_windows.go on lines 797..812

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 245.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            t.ctr.client.eventQ.Append(t.ctr.id, func() {
        err := t.ctr.client.backend.ProcessEvent(t.ctr.id, libcontainerdtypes.EventPaused, libcontainerdtypes.EventInfo{
            ContainerID: t.ctr.id,
            ProcessID:   t.id,
        })
                        Severity: Major
                        Found in libcontainerd/local/local_windows.go and 1 other location - About 2 hrs to fix
                        libcontainerd/local/local_windows.go on lines 838..853

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 245.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            defer func() {
        if retErr != nil {
            if err := newProcess.Kill(); err != nil {
                logger.WithError(err).Error("failed to kill process")
            }
                        Severity: Major
                        Found in libcontainerd/local/local_windows.go and 1 other location - About 1 hr to fix
                        libcontainerd/local/local_windows.go on lines 447..461

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 157.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            defer func() {
        if retErr != nil {
            if err := newProcess.Kill(); err != nil {
                logger.WithError(err).Error("failed to kill process")
            }
                        Severity: Major
                        Found in libcontainerd/local/local_windows.go and 1 other location - About 1 hr to fix
                        libcontainerd/local/local_windows.go on lines 615..629

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 157.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status