Sign upLogin

dotcloud/docker

View on GitHub
Star
libcontainerd/remote/client_io_windows.go

Summary

Maintainability
D
1 day
Test Coverage

Method client.newStdioPipes has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
Open

func (c *client) newStdioPipes(fifos *cio.FIFOSet) (_ *stdioPipes, err error) {
    p := &stdioPipes{}
    if fifos.Stdin != "" {
        c.logger.WithField("stdin", fifos.Stdin).Debug("listen")
        l, err := winio.ListenPipe(fifos.Stdin, nil)
Severity: Minor
Found in libcontainerd/remote/client_io_windows.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method client.newStdioPipes has 95 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *client) newStdioPipes(fifos *cio.FIFOSet) (_ *stdioPipes, err error) {
    p := &stdioPipes{}
    if fifos.Stdin != "" {
        c.logger.WithField("stdin", fifos.Stdin).Debug("listen")
        l, err := winio.ListenPipe(fifos.Stdin, nil)
Severity: Major
Found in libcontainerd/remote/client_io_windows.go - About 2 hrs to fix

    Method client.newStdioPipes has 7 return statements (exceeds 4 allowed).
    Open

    func (c *client) newStdioPipes(fifos *cio.FIFOSet) (_ *stdioPipes, err error) {
    p := &stdioPipes{}
    if fifos.Stdin != "" {
        c.logger.WithField("stdin", fifos.Stdin).Debug("listen")
        l, err := winio.ListenPipe(fifos.Stdin, nil)
    Severity: Major
    Found in libcontainerd/remote/client_io_windows.go - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if fifos.Stdin != "" {
        c.logger.WithField("stdin", fifos.Stdin).Debug("listen")
        l, err := winio.ListenPipe(fifos.Stdin, nil)
        if err != nil {
            return nil, errors.Wrapf(err, "failed to create stdin pipe %s", fifos.Stdin)
      Severity: Major
      Found in libcontainerd/remote/client_io_windows.go and 1 other location - About 4 hrs to fix
      libcontainerd/remote/client_io_windows.go on lines 127..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 319.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if fifos.Stderr != "" {
        c.logger.WithField("stderr", fifos.Stderr).Debug("listen")
        l, err := winio.ListenPipe(fifos.Stderr, nil)
        if err != nil {
            return nil, errors.Wrapf(err, "failed to create stderr pipe %s", fifos.Stderr)
      Severity: Major
      Found in libcontainerd/remote/client_io_windows.go and 1 other location - About 4 hrs to fix
      libcontainerd/remote/client_io_windows.go on lines 61..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 319.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status