Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/cmd/networkdb-test/dbclient/ndbClient.go

Summary

Maintainability
D
2 days
Test Coverage

File ndbClient.go has 662 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package dbclient

import (
    "context"
    "fmt"
Severity: Minor
Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go - About 5 hrs to fix

    Function Client has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func Client(args []string) {
    log.G(context.TODO()).Infof("[CLIENT] Starting with arguments %v", args)
    command := args[0]

    if len(args) < cmdArgCheck[command] {
    Severity: Minor
    Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go - About 1 hr to fix

      Function checkTable has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func checkTable(ctx context.Context, ips []string, port, networkName, tableName string, expectedEntries int, fn func(string, string, string, string, chan resultTuple)) (opTime time.Duration) {
    startTime := time.Now().UnixNano()
    var successTime int64

    // Loop for 2 minutes to guarantee that the result is stable
      Severity: Minor
      Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function checkTable has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func checkTable(ctx context.Context, ips []string, port, networkName, tableName string, expectedEntries int, fn func(string, string, string, string, chan resultTuple)) (opTime time.Duration) {
      Severity: Minor
      Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func clientTableEntriesNumber(ip, port, networkName, tableName string, doneCh chan resultTuple) {
    body, err := httpGet(ip, port, "/watchedtableentries?nid="+networkName+"&tname="+tableName)
    if err != nil {
        log.G(context.TODO()).Errorf("clientTableEntriesNumber %s there was an error: %s", ip, err)
        doneCh <- resultTuple{id: ip, result: -1}
        Severity: Major
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 1 hr to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 105..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 169.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func dbTableEntriesNumber(ip, port, networkName, tableName string, doneCh chan resultTuple) {
    body, err := httpGet(ip, port, "/gettable?nid="+networkName+"&tname="+tableName)
    if err != nil {
        log.G(context.TODO()).Errorf("tableEntriesNumber %s there was an error: %s", ip, err)
        doneCh <- resultTuple{id: ip, result: -1}
        Severity: Major
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 1 hr to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 136..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 169.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func networkPeersNumber(ip, port, networkName string, doneCh chan resultTuple) {
    body, err := httpGet(ip, port, "/networkpeers?nid="+networkName)
    if err != nil {
        log.G(context.TODO()).Errorf("networkPeersNumber %s there was an error: %s", ip, err)
        doneCh <- resultTuple{id: ip, result: -1}
        Severity: Major
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 1 hr to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 117..127

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 160.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func dbQueueLength(ip, port, networkName string, doneCh chan resultTuple) {
    body, err := httpGet(ip, port, "/networkstats?nid="+networkName)
    if err != nil {
        log.G(context.TODO()).Errorf("queueLength %s there was an error: %s", ip, err)
        doneCh <- resultTuple{id: ip, result: -1}
        Severity: Major
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 1 hr to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 92..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 160.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                for i := len(ips); i > 0; i-- {
            node := <-doneCh
            if node.result != expectedPeers {
                failed = true
                if retry == maxRetry-1 {
        Severity: Major
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 1 hr to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 408..419

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                for i := len(ips); i > 0; i-- {
            node := <-doneCh
            if node.result != expectedPeers {
                failed = true
                if retry == maxRetry-1 {
        Severity: Major
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 1 hr to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 347..358

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func doLeaveNetwork(ips []string, args []string) {
    doneCh := make(chan resultTuple, len(ips))
    // check all the nodes
    for _, ip := range ips {
        go leaveNetwork(ip, servicePort, args[0], doneCh)
        Severity: Minor
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 35 mins to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 368..379

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func doJoinNetwork(ips []string, args []string) {
    doneCh := make(chan resultTuple, len(ips))
    // check all the nodes
    for _, ip := range ips {
        go joinNetwork(ip, servicePort, args[0], doneCh)
        Severity: Minor
        Found in libnetwork/cmd/networkdb-test/dbclient/ndbClient.go and 1 other location - About 35 mins to fix
        libnetwork/cmd/networkdb-test/dbclient/ndbClient.go on lines 382..393

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status