Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/default_gateway.go

Summary

Maintainability
A
1 hr
Test Coverage

Method Sandbox.setupDefaultGW has 5 return statements (exceeds 4 allowed).
Open

func (sb *Sandbox) setupDefaultGW() error {
    // check if the container already has a GW endpoint
    if ep := sb.getEndpointInGWNetwork(); ep != nil {
        return nil
    }
Severity: Major
Found in libnetwork/default_gateway.go - About 35 mins to fix

    Method Sandbox.needDefaultGW has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
    Open

    func (sb *Sandbox) needDefaultGW() bool {
    var needGW bool

    for _, ep := range sb.Endpoints() {
        if ep.endpointInGWNetwork() {
    Severity: Minor
    Found in libnetwork/default_gateway.go - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status