Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/drivers/bridge/setup_ip_tables_linux.go

Summary

Maintainability
C
1 day
Test Coverage

Function setupIPChains has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func setupIPChains(config configuration, version iptables.IPVersion) (natChain *iptables.ChainInfo, filterChain *iptables.ChainInfo, isolationChain1 *iptables.ChainInfo, isolationChain2 *iptables.ChainInfo, retErr error) {
    // Sanity check.
    if version == iptables.IPv4 && !config.EnableIPTables {
        return nil, nil, nil, nil, errors.New("cannot create new chains, iptables is disabled")
    }
Severity: Minor
Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setupIPChains has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func setupIPChains(config configuration, version iptables.IPVersion) (natChain *iptables.ChainInfo, filterChain *iptables.ChainInfo, isolationChain1 *iptables.ChainInfo, isolationChain2 *iptables.ChainInfo, retErr error) {
    // Sanity check.
    if version == iptables.IPv4 && !config.EnableIPTables {
        return nil, nil, nil, nil, errors.New("cannot create new chains, iptables is disabled")
    }
Severity: Minor
Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go - About 1 hr to fix

    Method bridgeNetwork.setupIPTables has 11 return statements (exceeds 4 allowed).
    Open

    func (n *bridgeNetwork) setupIPTables(ipVersion iptables.IPVersion, maskedAddr *net.IPNet, config *networkConfiguration, i *bridgeInterface) error {
    var err error

    d := n.driver
    d.Lock()
    Severity: Major
    Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go - About 1 hr to fix

      Function setupIPChains has 10 return statements (exceeds 4 allowed).
      Open

      func setupIPChains(config configuration, version iptables.IPVersion) (natChain *iptables.ChainInfo, filterChain *iptables.ChainInfo, isolationChain1 *iptables.ChainInfo, isolationChain2 *iptables.ChainInfo, retErr error) {
    // Sanity check.
    if version == iptables.IPv4 && !config.EnableIPTables {
        return nil, nil, nil, nil, errors.New("cannot create new chains, iptables is disabled")
    }
      Severity: Major
      Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go - About 1 hr to fix

        Function setupIPTablesInternal has 6 return statements (exceeds 4 allowed).
        Open

        func setupIPTablesInternal(ipVer iptables.IPVersion, config *networkConfiguration, addr *net.IPNet, hairpin, enable bool) error {
    var (
        address   = addr.String()
        skipDNAT  = iptRule{ipv: ipVer, table: iptables.Nat, chain: DockerChain, args: []string{"-i", config.BridgeName, "-j", "RETURN"}}
        outRule   = iptRule{ipv: ipVer, table: iptables.Filter, chain: "FORWARD", args: []string{"-i", config.BridgeName, "!", "-o", config.BridgeName, "-j", "ACCEPT"}}
        Severity: Major
        Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go - About 40 mins to fix

          Function setupInternalNetworkRules has 5 return statements (exceeds 4 allowed).
          Open

          func setupInternalNetworkRules(bridgeIface string, addr *net.IPNet, icc, insert bool) error {
    var version iptables.IPVersion
    var inDropRule, outDropRule iptRule

    // Either add or remove the interface from the firewalld zone, if firewalld is running.
          Severity: Major
          Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (n *bridgeNetwork) setupIP4Tables(config *networkConfiguration, i *bridgeInterface) error {
    d := n.driver
    d.Lock()
    driverConfig := d.config
    d.Unlock()
            Severity: Major
            Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go and 1 other location - About 1 hr to fix
            libnetwork/drivers/bridge/setup_ip_tables_linux.go on lines 134..151

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 174.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (n *bridgeNetwork) setupIP6Tables(config *networkConfiguration, i *bridgeInterface) error {
    d := n.driver
    d.Lock()
    driverConfig := d.config
    d.Unlock()
            Severity: Major
            Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go and 1 other location - About 1 hr to fix
            libnetwork/drivers/bridge/setup_ip_tables_linux.go on lines 116..132

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 174.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func programChainRule(rule iptRule, ruleDescr string, insert bool) error {
    operation := "disable"
    fn := rule.Delete
    if insert {
        operation = "enable"
            Severity: Minor
            Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go and 1 other location - About 35 mins to fix
            libnetwork/drivers/bridge/setup_ip_tables_linux.go on lines 366..377

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func appendOrDelChainRule(rule iptRule, ruleDescr string, append bool) error {
    operation := "disable"
    fn := rule.Delete
    if append {
        operation = "enable"
            Severity: Minor
            Found in libnetwork/drivers/bridge/setup_ip_tables_linux.go and 1 other location - About 35 mins to fix
            libnetwork/drivers/bridge/setup_ip_tables_linux.go on lines 353..364

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status