dotcloud/docker

Function createVlanLink has 7 return statements (exceeds 4 allowed).

Open

func createVlanLink(parentName string) error {
    if strings.Contains(parentName, ".") {
        parent, vidInt, err := parseVlan(parentName)
        if err != nil {
            return err

Function createMacVlan has 5 return statements (exceeds 4 allowed).

Open

func createMacVlan(containerIfName, parent, macvlanMode string) (string, error) {
    // Set the macvlan mode. Default is bridge mode
    mode, err := setMacVlanMode(macvlanMode)
    if err != nil {
        return "", fmt.Errorf("Unsupported %s macvlan mode: %v", macvlanMode, err)

Function delVlanLink has 5 return statements (exceeds 4 allowed).

Open

func delVlanLink(linkName string) error {
    if strings.Contains(linkName, ".") {
        _, _, err := parseVlan(linkName)
        if err != nil {
            return err

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func createVlanLink(parentName string) error {
    if strings.Contains(parentName, ".") {
        parent, vidInt, err := parseVlan(parentName)
        if err != nil {
            return err

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func delVlanLink(linkName string) error {
    if strings.Contains(linkName, ".") {
        _, _, err := parseVlan(linkName)
        if err != nil {
            return err

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func createDummyLink(dummyName, truncNetID string) error {
    // create a parent interface since one was not specified
    parent := &netlink.Dummy{
        LinkAttrs: netlink.LinkAttrs{
            Name: dummyName,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func delDummyLink(linkName string) error {
    // delete the vlan subinterface
    dummyLink, err := ns.NlHandle().LinkByName(linkName)
    if err != nil {
        return fmt.Errorf("failed to find link %s on the Docker host : %v", linkName, err)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func parseVlan(linkName string) (string, int, error) {
    // parse -o parent=eth0.10
    splitName := strings.Split(linkName, ".")
    if len(splitName) != 2 {
        return "", 0, fmt.Errorf("required interface name format is: name.vlan_id, ex. eth0.10 for vlan 10, instead received %s", linkName)

• Read up
  Read up