Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/drivers/overlay/joinleave.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method driver.Join has 89 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (d *driver) Join(ctx context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) error {
    ctx, span := otel.Tracer("").Start(ctx, "libnetwork.drivers.overlay.Join", trace.WithAttributes(
        attribute.String("nid", nid),
        attribute.String("eid", eid),
        attribute.String("sboxKey", sboxKey)))
Severity: Major
Found in libnetwork/drivers/overlay/joinleave.go - About 2 hrs to fix

    Method driver.Join has 17 return statements (exceeds 4 allowed).
    Open

    func (d *driver) Join(ctx context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) error {
    ctx, span := otel.Tracer("").Start(ctx, "libnetwork.drivers.overlay.Join", trace.WithAttributes(
        attribute.String("nid", nid),
        attribute.String("eid", eid),
        attribute.String("sboxKey", sboxKey)))
    Severity: Major
    Found in libnetwork/drivers/overlay/joinleave.go - About 1 hr to fix

      Method driver.Join has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
      Open

      func (d *driver) Join(ctx context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) error {
    ctx, span := otel.Tracer("").Start(ctx, "libnetwork.drivers.overlay.Join", trace.WithAttributes(
        attribute.String("nid", nid),
        attribute.String("eid", eid),
        attribute.String("sboxKey", sboxKey)))
      Severity: Minor
      Found in libnetwork/drivers/overlay/joinleave.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method driver.EventNotify has 7 return statements (exceeds 4 allowed).
      Open

      func (d *driver) EventNotify(etype driverapi.EventType, nid, tableName, key string, value []byte) {
    if tableName != ovPeerTable {
        log.G(context.TODO()).Errorf("Unexpected table notification for table %s received", tableName)
        return
    }
      Severity: Major
      Found in libnetwork/drivers/overlay/joinleave.go - About 45 mins to fix

        Method driver.Join has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (d *driver) Join(ctx context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) error {
        Severity: Minor
        Found in libnetwork/drivers/overlay/joinleave.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status