Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/drivers/overlay/ovmanager/ovmanager.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method driver.NetworkAllocate has 60 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (d *driver) NetworkAllocate(id string, option map[string]string, ipV4Data, ipV6Data []driverapi.IPAMData) (map[string]string, error) {
    if id == "" {
        return nil, fmt.Errorf("invalid network id for overlay network")
    }
Severity: Minor
Found in libnetwork/drivers/overlay/ovmanager/ovmanager.go - About 1 hr to fix

    Method driver.NetworkAllocate has 7 return statements (exceeds 4 allowed).
    Open

    func (d *driver) NetworkAllocate(id string, option map[string]string, ipV4Data, ipV6Data []driverapi.IPAMData) (map[string]string, error) {
    if id == "" {
        return nil, fmt.Errorf("invalid network id for overlay network")
    }
    Severity: Major
    Found in libnetwork/drivers/overlay/ovmanager/ovmanager.go - About 45 mins to fix

      Method driver.Join has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (d *driver) Join(_ context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) error {
      Severity: Minor
      Found in libnetwork/drivers/overlay/ovmanager/ovmanager.go - About 35 mins to fix

        Method driver.NetworkAllocate has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func (d *driver) NetworkAllocate(id string, option map[string]string, ipV4Data, ipV6Data []driverapi.IPAMData) (map[string]string, error) {
    if id == "" {
        return nil, fmt.Errorf("invalid network id for overlay network")
    }
        Severity: Minor
        Found in libnetwork/drivers/overlay/ovmanager/ovmanager.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status