Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/drivers/remote/driver.go

Summary

Maintainability
C
1 day
Test Coverage

Method driver.Join has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func (d *driver) Join(_ context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) (retErr error) {
    join := &api.JoinRequest{
        NetworkID:  nid,
        EndpointID: eid,
        SandboxKey: sboxKey,
Severity: Minor
Found in libnetwork/drivers/remote/driver.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method driver.Join has 60 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (d *driver) Join(_ context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) (retErr error) {
    join := &api.JoinRequest{
        NetworkID:  nid,
        EndpointID: eid,
        SandboxKey: sboxKey,
Severity: Minor
Found in libnetwork/drivers/remote/driver.go - About 1 hr to fix

    Method driver.CreateEndpoint has 55 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (d *driver) CreateEndpoint(_ context.Context, nid, eid string, ifInfo driverapi.InterfaceInfo, epOptions map[string]interface{}) (retErr error) {
    if ifInfo == nil {
        return errors.New("must not be called with nil InterfaceInfo")
    }
    Severity: Minor
    Found in libnetwork/drivers/remote/driver.go - About 1 hr to fix

      Method driver.Join has 9 return statements (exceeds 4 allowed).
      Open

      func (d *driver) Join(_ context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) (retErr error) {
    join := &api.JoinRequest{
        NetworkID:  nid,
        EndpointID: eid,
        SandboxKey: sboxKey,
      Severity: Major
      Found in libnetwork/drivers/remote/driver.go - About 55 mins to fix

        Method driver.CreateEndpoint has 8 return statements (exceeds 4 allowed).
        Open

        func (d *driver) CreateEndpoint(_ context.Context, nid, eid string, ifInfo driverapi.InterfaceInfo, epOptions map[string]interface{}) (retErr error) {
    if ifInfo == nil {
        return errors.New("must not be called with nil InterfaceInfo")
    }
        Severity: Major
        Found in libnetwork/drivers/remote/driver.go - About 50 mins to fix

          Method driver.Join has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (d *driver) Join(_ context.Context, nid, eid string, sboxKey string, jinfo driverapi.JoinInfo, options map[string]interface{}) (retErr error) {
          Severity: Minor
          Found in libnetwork/drivers/remote/driver.go - About 35 mins to fix

            Function getPluginClient has 5 return statements (exceeds 4 allowed).
            Open

            func getPluginClient(p plugingetter.CompatPlugin) (*plugins.Client, error) {
    if v1, ok := p.(plugingetter.PluginWithV1Client); ok {
        return v1.Client(), nil
    }
            Severity: Major
            Found in libnetwork/drivers/remote/driver.go - About 35 mins to fix

              Method driver.CreateEndpoint has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func (d *driver) CreateEndpoint(_ context.Context, nid, eid string, ifInfo driverapi.InterfaceInfo, epOptions map[string]interface{}) (retErr error) {
    if ifInfo == nil {
        return errors.New("must not be called with nil InterfaceInfo")
    }
              Severity: Minor
              Found in libnetwork/drivers/remote/driver.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              func getPluginClient(p plugingetter.CompatPlugin) (*plugins.Client, error) {
    if v1, ok := p.(plugingetter.PluginWithV1Client); ok {
        return v1.Client(), nil
    }
              Severity: Major
              Found in libnetwork/drivers/remote/driver.go and 1 other location - About 2 hrs to fix
              libnetwork/ipams/remote/remote.go on lines 68..88

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 220.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (d *driver) DiscoverNew(dType discoverapi.DiscoveryType, data interface{}) error {
    if dType != discoverapi.NodeDiscovery {
        return nil
    }
    notif := &api.DiscoveryNotification{
              Severity: Minor
              Found in libnetwork/drivers/remote/driver.go and 1 other location - About 40 mins to fix
              libnetwork/drivers/remote/driver.go on lines 386..395

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 109.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (d *driver) DiscoverDelete(dType discoverapi.DiscoveryType, data interface{}) error {
    if dType != discoverapi.NodeDiscovery {
        return nil
    }
    notif := &api.DiscoveryNotification{
              Severity: Minor
              Found in libnetwork/drivers/remote/driver.go and 1 other location - About 40 mins to fix
              libnetwork/drivers/remote/driver.go on lines 374..383

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 109.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status