Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/drivers/windows/overlay/overlay.pb.go

Summary

Maintainability
F
5 days
Test Coverage

Method PeerRecord.Unmarshal has a Cognitive Complexity of 100 (exceeds 20 allowed). Consider refactoring.
Open

func (m *PeerRecord) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
Severity: Minor
Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function skipOverlay has a Cognitive Complexity of 78 (exceeds 20 allowed). Consider refactoring.
Open

func skipOverlay(dAtA []byte) (n int, err error) {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        var wire uint64
Severity: Minor
Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PeerRecord.Unmarshal has 134 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m *PeerRecord) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
Severity: Major
Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 4 hrs to fix

    Function skipOverlay has 97 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func skipOverlay(dAtA []byte) (n int, err error) {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        var wire uint64
    Severity: Major
    Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 2 hrs to fix

      Method PeerRecord.Unmarshal has 24 return statements (exceeds 4 allowed).
      Open

      func (m *PeerRecord) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
      Severity: Major
      Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 2 hrs to fix

        Function skipOverlay has 15 return statements (exceeds 4 allowed).
        Open

        func skipOverlay(dAtA []byte) (n int, err error) {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        var wire uint64
        Severity: Major
        Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                              if shift >= 64 {
                        return 0, ErrIntOverflowOverlay
                    }
          Severity: Major
          Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if b < 0x80 {
                        break
                    }
            Severity: Major
            Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if iNdEx >= l {
                        return 0, io.ErrUnexpectedEOF
                    }
              Severity: Major
              Found in libnetwork/drivers/windows/overlay/overlay.pb.go - About 45 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        case 3:
            if wireType != 2 {
                return fmt.Errorf("proto: wrong wireType = %d for field TunnelEndpointIP", wireType)
            }
            var stringLen uint64
                Severity: Major
                Found in libnetwork/drivers/windows/overlay/overlay.pb.go and 2 other locations - About 2 hrs to fix
                libnetwork/drivers/windows/overlay/overlay.pb.go on lines 224..252
                libnetwork/drivers/windows/overlay/overlay.pb.go on lines 253..281

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 199.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        case 2:
            if wireType != 2 {
                return fmt.Errorf("proto: wrong wireType = %d for field EndpointMAC", wireType)
            }
            var stringLen uint64
                Severity: Major
                Found in libnetwork/drivers/windows/overlay/overlay.pb.go and 2 other locations - About 2 hrs to fix
                libnetwork/drivers/windows/overlay/overlay.pb.go on lines 224..252
                libnetwork/drivers/windows/overlay/overlay.pb.go on lines 282..310

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 199.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        case 1:
            if wireType != 2 {
                return fmt.Errorf("proto: wrong wireType = %d for field EndpointIP", wireType)
            }
            var stringLen uint64
                Severity: Major
                Found in libnetwork/drivers/windows/overlay/overlay.pb.go and 2 other locations - About 2 hrs to fix
                libnetwork/drivers/windows/overlay/overlay.pb.go on lines 253..281
                libnetwork/drivers/windows/overlay/overlay.pb.go on lines 282..310

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 199.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                func (this *PeerRecord) GoString() string {
    if this == nil {
        return "nil"
    }
    s := make([]string, 0, 7)
                Severity: Major
                Found in libnetwork/drivers/windows/overlay/overlay.pb.go and 2 other locations - About 1 hr to fix
                libnetwork/drivers/overlay/overlay.pb.go on lines 121..132
                libnetwork/networkdb/networkdb.pb.go on lines 839..850

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 177.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                func (this *PeerRecord) String() string {
    if this == nil {
        return "nil"
    }
    s := strings.Join([]string{`&PeerRecord{`,
                Severity: Major
                Found in libnetwork/drivers/windows/overlay/overlay.pb.go and 2 other locations - About 1 hr to fix
                libnetwork/drivers/overlay/overlay.pb.go on lines 223..234
                libnetwork/networkdb/networkdb.pb.go on lines 1602..1613

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 129.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status