Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/drivers/windows/overlay/peerdb_windows.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method driver.peerAdd has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (d *driver) peerAdd(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, peerMac net.HardwareAddr, vtep net.IP, updateDb bool) error {
Severity: Minor
Found in libnetwork/drivers/windows/overlay/peerdb_windows.go - About 45 mins to fix

    Method driver.peerDelete has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (d *driver) peerDelete(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, peerMac net.HardwareAddr, vtep net.IP, updateDb bool) error {
    Severity: Minor
    Found in libnetwork/drivers/windows/overlay/peerdb_windows.go - About 45 mins to fix

      Method driver.peerAdd has 7 return statements (exceeds 4 allowed).
      Open

      func (d *driver) peerAdd(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, peerMac net.HardwareAddr, vtep net.IP, updateDb bool) error {
    log.G(context.TODO()).Debugf("WINOVERLAY: Enter peerAdd for ca ip %s with ca mac %s", peerIP.String(), peerMac.String())

    if err := validateID(nid, eid); err != nil {
        return err
      Severity: Major
      Found in libnetwork/drivers/windows/overlay/peerdb_windows.go - About 45 mins to fix

        Method driver.peerDelete has 5 return statements (exceeds 4 allowed).
        Open

        func (d *driver) peerDelete(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, peerMac net.HardwareAddr, vtep net.IP, updateDb bool) error {
    log.G(context.TODO()).Infof("WINOVERLAY: Enter peerDelete for endpoint %s and peer ip %s", eid, peerIP.String())

    if err := validateID(nid, eid); err != nil {
        return err
        Severity: Major
        Found in libnetwork/drivers/windows/overlay/peerdb_windows.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status