Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/iptables/iptables.go

Summary

Maintainability
D
2 days
Test Coverage

Method IPTable.ProgramChain has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
Open

func (iptable IPTable) ProgramChain(c *ChainInfo, bridgeName string, hairpinMode, enable bool) error {
    if c.Name == "" {
        return errors.New("could not program chain, missing chain name")
    }
Severity: Minor
Found in libnetwork/iptables/iptables.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method IPTable.ProgramChain has 91 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (iptable IPTable) ProgramChain(c *ChainInfo, bridgeName string, hairpinMode, enable bool) error {
    if c.Name == "" {
        return errors.New("could not program chain, missing chain name")
    }
Severity: Major
Found in libnetwork/iptables/iptables.go - About 2 hrs to fix

    Method IPTable.ProgramChain has 17 return statements (exceeds 4 allowed).
    Open

    func (iptable IPTable) ProgramChain(c *ChainInfo, bridgeName string, hairpinMode, enable bool) error {
    if c.Name == "" {
        return errors.New("could not program chain, missing chain name")
    }
    Severity: Major
    Found in libnetwork/iptables/iptables.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  } else if len(output) != 0 {
                return fmt.Errorf("could not delete establish rule from %s: %s", c.Table, output)
            }
      Severity: Major
      Found in libnetwork/iptables/iptables.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    } else if len(output) != 0 {
                return fmt.Errorf("could not delete linking rule from %s/%s: %s", c.Table, c.Name, output)
            }
        Severity: Major
        Found in libnetwork/iptables/iptables.go - About 45 mins to fix

          Method ChainInfo.Link has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (c *ChainInfo) Link(action Action, ip1, ip2 net.IP, port int, proto string, bridgeName string) error {
          Severity: Minor
          Found in libnetwork/iptables/iptables.go - About 35 mins to fix

            Method IPTable.NewChain has 5 return statements (exceeds 4 allowed).
            Open

            func (iptable IPTable) NewChain(name string, table Table) (*ChainInfo, error) {
    if name == "" {
        return nil, fmt.Errorf("could not create chain: chain name is empty")
    }
    if table == "" {
            Severity: Major
            Found in libnetwork/iptables/iptables.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if !iptable.Exists(Nat, "OUTPUT", output...) && enable {
            if err := c.Output(Append, output...); err != nil {
                return fmt.Errorf("failed to inject %s in OUTPUT chain: %s", c.Name, err)
            }
        } else if iptable.Exists(Nat, "OUTPUT", output...) && !enable {
              Severity: Minor
              Found in libnetwork/iptables/iptables.go and 1 other location - About 1 hr to fix
              libnetwork/iptables/iptables.go on lines 221..229

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 129.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if !iptable.Exists(Nat, "PREROUTING", preroute...) && enable {
            if err := c.Prerouting(Append, preroute...); err != nil {
                return fmt.Errorf("failed to inject %s in PREROUTING chain: %s", c.Name, err)
            }
        } else if iptable.Exists(Nat, "PREROUTING", preroute...) && !enable {
              Severity: Minor
              Found in libnetwork/iptables/iptables.go and 1 other location - About 1 hr to fix
              libnetwork/iptables/iptables.go on lines 238..246

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 129.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status