Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/networkdb/delegate.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method NetworkDB.handleTableEvent has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (nDB *NetworkDB) handleTableEvent(tEvent *TableEvent, isBulkSync bool) bool {
    // Update our local clock if the received messages has newer time.
    nDB.tableClock.Witness(tEvent.LTime)

    // Ignore the table events for networks that are in the process of going away
Severity: Minor
Found in libnetwork/networkdb/delegate.go - About 1 hr to fix

    Method NetworkDB.handleNodeEvent has 8 return statements (exceeds 4 allowed).
    Open

    func (nDB *NetworkDB) handleNodeEvent(nEvent *NodeEvent) bool {
    // Update our local clock if the received messages has newer
    // time.
    nDB.networkClock.Witness(nEvent.LTime)
    Severity: Major
    Found in libnetwork/networkdb/delegate.go - About 50 mins to fix

      Method NetworkDB.handleNetworkEvent has 7 return statements (exceeds 4 allowed).
      Open

      func (nDB *NetworkDB) handleNetworkEvent(nEvent *NetworkEvent) bool {
    // Update our local clock if the received messages has newer
    // time.
    nDB.networkClock.Witness(nEvent.LTime)
      Severity: Major
      Found in libnetwork/networkdb/delegate.go - About 45 mins to fix

        Method NetworkDB.handleTableMessage has 5 return statements (exceeds 4 allowed).
        Open

        func (nDB *NetworkDB) handleTableMessage(buf []byte, isBulkSync bool) {
    var tEvent TableEvent
    if err := proto.Unmarshal(buf, &tEvent); err != nil {
        log.G(context.TODO()).Errorf("Error decoding table event message: %v", err)
        return
        Severity: Major
        Found in libnetwork/networkdb/delegate.go - About 35 mins to fix

          Method NetworkDB.handleTableEvent has 5 return statements (exceeds 4 allowed).
          Open

          func (nDB *NetworkDB) handleTableEvent(tEvent *TableEvent, isBulkSync bool) bool {
    // Update our local clock if the received messages has newer time.
    nDB.tableClock.Witness(tEvent.LTime)

    // Ignore the table events for networks that are in the process of going away
          Severity: Major
          Found in libnetwork/networkdb/delegate.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case NodeEventTypeJoin:
        moved, err := nDB.changeNodeState(n.Name, nodeActiveState)
        if err != nil {
            log.G(context.TODO()).WithError(err).Error("unable to find the node to move")
            return false
            Severity: Major
            Found in libnetwork/networkdb/delegate.go and 1 other location - About 1 hr to fix
            libnetwork/networkdb/delegate.go on lines 60..69

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 131.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case NodeEventTypeLeave:
        moved, err := nDB.changeNodeState(n.Name, nodeLeftState)
        if err != nil {
            log.G(context.TODO()).WithError(err).Error("unable to find the node to move")
            return false
            Severity: Major
            Found in libnetwork/networkdb/delegate.go and 1 other location - About 1 hr to fix
            libnetwork/networkdb/delegate.go on lines 50..59

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 131.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status