Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/resolver.go

Summary

Maintainability
C
1 day
Test Coverage

File resolver.go has 516 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package libnetwork

import (
    "context"
    "errors"
Severity: Minor
Found in libnetwork/resolver.go - About 2 hrs to fix

    Method Resolver.serveDNS has 74 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r *Resolver) serveDNS(w dns.ResponseWriter, query *dns.Msg) {
    var (
        resp *dns.Msg
        err  error
    )
    Severity: Minor
    Found in libnetwork/resolver.go - About 1 hr to fix

      Method Resolver.serveDNS has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r *Resolver) serveDNS(w dns.ResponseWriter, query *dns.Msg) {
    var (
        resp *dns.Msg
        err  error
    )
      Severity: Minor
      Found in libnetwork/resolver.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Resolver.forwardExtDNS has 60 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (r *Resolver) forwardExtDNS(ctx context.Context, proto string, remoteAddr net.Addr, query *dns.Msg) *dns.Msg {
    ctx, span := otel.Tracer("").Start(ctx, "resolver.forwardExtDNS")
    defer span.End()

    proxyDNS := r.proxyDNS.Load()
      Severity: Minor
      Found in libnetwork/resolver.go - About 1 hr to fix

        Method Resolver.forwardExtDNS has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func (r *Resolver) forwardExtDNS(ctx context.Context, proto string, remoteAddr net.Addr, query *dns.Msg) *dns.Msg {
    ctx, span := otel.Tracer("").Start(ctx, "resolver.forwardExtDNS")
    defer span.End()

    proxyDNS := r.proxyDNS.Load()
        Severity: Minor
        Found in libnetwork/resolver.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status