Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/sandbox_linux.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Sandbox.populateNetworkResources has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func (sb *Sandbox) populateNetworkResources(ctx context.Context, ep *Endpoint) error {
    ctx, span := otel.Tracer("").Start(ctx, "libnetwork.Sandbox.populateNetworkResources", trace.WithAttributes(
        attribute.String("endpoint.Name", ep.Name())))
    defer span.End()
Severity: Minor
Found in libnetwork/sandbox_linux.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Sandbox.populateNetworkResources has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (sb *Sandbox) populateNetworkResources(ctx context.Context, ep *Endpoint) error {
    ctx, span := otel.Tracer("").Start(ctx, "libnetwork.Sandbox.populateNetworkResources", trace.WithAttributes(
        attribute.String("endpoint.Name", ep.Name())))
    defer span.End()
Severity: Minor
Found in libnetwork/sandbox_linux.go - About 1 hr to fix

    Method Sandbox.populateNetworkResources has 8 return statements (exceeds 4 allowed).
    Open

    func (sb *Sandbox) populateNetworkResources(ctx context.Context, ep *Endpoint) error {
    ctx, span := otel.Tracer("").Start(ctx, "libnetwork.Sandbox.populateNetworkResources", trace.WithAttributes(
        attribute.String("endpoint.Name", ep.Name())))
    defer span.End()
    Severity: Major
    Found in libnetwork/sandbox_linux.go - About 50 mins to fix

      Method Sandbox.SetKey has 6 return statements (exceeds 4 allowed).
      Open

      func (sb *Sandbox) SetKey(ctx context.Context, basePath string) error {
    start := time.Now()
    defer func() {
        log.G(ctx).Debugf("sandbox set key processing took %s for container %s", time.Since(start), sb.ContainerID())
    }()
      Severity: Major
      Found in libnetwork/sandbox_linux.go - About 40 mins to fix

        Method Sandbox.updateGateway has 5 return statements (exceeds 4 allowed).
        Open

        func (sb *Sandbox) updateGateway(ep *Endpoint) error {
    sb.mu.Lock()
    osSbox := sb.osSbox
    sb.mu.Unlock()
    if osSbox == nil {
        Severity: Major
        Found in libnetwork/sandbox_linux.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status