Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/sandbox_store.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Controller.sandboxCleanup has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Controller) sandboxCleanup(activeSandboxes map[string]interface{}) error {
    sandboxStates, err := c.store.List(&sbState{c: c})
    if err != nil {
        if err == datastore.ErrKeyNotFound {
            // It's normal for no sandboxes to be found. Just bail out.
Severity: Minor
Found in libnetwork/sandbox_store.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Controller.sandboxCleanup has 100 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Controller) sandboxCleanup(activeSandboxes map[string]interface{}) error {
    sandboxStates, err := c.store.List(&sbState{c: c})
    if err != nil {
        if err == datastore.ErrKeyNotFound {
            // It's normal for no sandboxes to be found. Just bail out.
Severity: Major
Found in libnetwork/sandbox_store.go - About 3 hrs to fix

    There are no issues that match your filters.

    Category
    Status