Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/service_common.go

Summary

Maintainability
C
1 day
Test Coverage

Method Controller.rmServiceBinding has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Controller) rmServiceBinding(svcName, svcID, nID, eID, containerName string, vip net.IP, ingressPorts []*PortConfig, serviceAliases []string, taskAliases []string, ip net.IP, method string, deleteSvcRecords bool, fullRemove bool) error {
    var rmService bool

    skey := serviceKey{
        id:    svcID,
Severity: Minor
Found in libnetwork/service_common.go - About 1 hr to fix

    Method Controller.addServiceBinding has 58 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (c *Controller) addServiceBinding(svcName, svcID, nID, eID, containerName string, vip net.IP, ingressPorts []*PortConfig, serviceAliases, taskAliases []string, ip net.IP, method string) error {
    var addService bool

    // Failure to lock the network ID on add can result in racing
    // against network deletion resulting in inconsistent state
    Severity: Minor
    Found in libnetwork/service_common.go - About 1 hr to fix

      Method Controller.rmServiceBinding has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (c *Controller) rmServiceBinding(svcName, svcID, nID, eID, containerName string, vip net.IP, ingressPorts []*PortConfig, serviceAliases []string, taskAliases []string, ip net.IP, method string, deleteSvcRecords bool, fullRemove bool) error {
      Severity: Major
      Found in libnetwork/service_common.go - About 1 hr to fix

        Method Controller.addEndpointNameResolution has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (c *Controller) addEndpointNameResolution(svcName, svcID, nID, eID, containerName string, vip net.IP, serviceAliases, taskAliases []string, ip net.IP, addService bool, method string) error {
        Severity: Minor
        Found in libnetwork/service_common.go - About 45 mins to fix

          Method Controller.addServiceBinding has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (c *Controller) addServiceBinding(svcName, svcID, nID, eID, containerName string, vip net.IP, ingressPorts []*PortConfig, serviceAliases, taskAliases []string, ip net.IP, method string) error {
          Severity: Minor
          Found in libnetwork/service_common.go - About 45 mins to fix

            Method Controller.deleteEndpointNameResolution has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (c *Controller) deleteEndpointNameResolution(svcName, svcID, nID, eID, containerName string, vip net.IP, serviceAliases, taskAliases []string, ip net.IP, rmService, multipleEntries bool, method string) error {
            Severity: Minor
            Found in libnetwork/service_common.go - About 45 mins to fix

              Function makeServiceCleanupFunc has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func makeServiceCleanupFunc(c *Controller, s *service, nID, eID string, vip net.IP, ip net.IP) func() {
              Severity: Minor
              Found in libnetwork/service_common.go - About 35 mins to fix

                Method Controller.rmServiceBinding has 5 return statements (exceeds 4 allowed).
                Open

                func (c *Controller) rmServiceBinding(svcName, svcID, nID, eID, containerName string, vip net.IP, ingressPorts []*PortConfig, serviceAliases []string, taskAliases []string, ip net.IP, method string, deleteSvcRecords bool, fullRemove bool) error {
    var rmService bool

    skey := serviceKey{
        id:    svcID,
                Severity: Major
                Found in libnetwork/service_common.go - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (c *Controller) addContainerNameResolution(nID, eID, containerName string, taskAliases []string, ip net.IP, method string) error {
    n, err := c.NetworkByID(nID)
    if err != nil {
        return err
    }
                  Severity: Major
                  Found in libnetwork/service_common.go and 1 other location - About 1 hr to fix
                  libnetwork/service_common.go on lines 121..137

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 156.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (c *Controller) delContainerNameResolution(nID, eID, containerName string, taskAliases []string, ip net.IP, method string) error {
    n, err := c.NetworkByID(nID)
    if err != nil {
        return err
    }
                  Severity: Major
                  Found in libnetwork/service_common.go and 1 other location - About 1 hr to fix
                  libnetwork/service_common.go on lines 57..73

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 156.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status