Sign upLogin

dotcloud/docker

View on GitHub
Star
pkg/archive/changes.go

Summary

Maintainability
C
1 day
Test Coverage

Function changes has a Cognitive Complexity of 52 (exceeds 20 allowed). Consider refactoring.
Open

func changes(layers []string, rw string, dc deleteChange, sc skipChange) ([]Change, error) {
    var (
        changes     []Change
        changedDirs = make(map[string]struct{})
    )
Severity: Minor
Found in pkg/archive/changes.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function changes has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func changes(layers []string, rw string, dc deleteChange, sc skipChange) ([]Change, error) {
    var (
        changes     []Change
        changedDirs = make(map[string]struct{})
    )
Severity: Minor
Found in pkg/archive/changes.go - About 1 hr to fix

    Function changes has 10 return statements (exceeds 4 allowed).
    Open

    func changes(layers []string, rw string, dc deleteChange, sc skipChange) ([]Change, error) {
    var (
        changes     []Change
        changedDirs = make(map[string]struct{})
    )
    Severity: Major
    Found in pkg/archive/changes.go - About 1 hr to fix

      Function ChangesSize has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

      func ChangesSize(newDir string, changes []Change) int64 {
    var (
        size int64
        sf   = make(map[uint64]struct{})
    )
      Severity: Minor
      Found in pkg/archive/changes.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status