Sign upLogin

dotcloud/docker

View on GitHub
Star
pkg/archive/changes_linux.go

Summary

Maintainability
C
1 day
Test Coverage

Method walker.walk has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
Open

func (w *walker) walk(path string, i1, i2 os.FileInfo) (err error) {
    // Register these nodes with the return trees, unless we're still at the
    // (already-created) roots:
    if path != "/" {
        if err := walkchunk(path, i1, w.dir1, w.root1); err != nil {
Severity: Minor
Found in pkg/archive/changes_linux.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method walker.walk has 89 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (w *walker) walk(path string, i1, i2 os.FileInfo) (err error) {
    // Register these nodes with the return trees, unless we're still at the
    // (already-created) roots:
    if path != "/" {
        if err := walkchunk(path, i1, w.dir1, w.root1); err != nil {
Severity: Major
Found in pkg/archive/changes_linux.go - About 2 hrs to fix

    Method walker.walk has 9 return statements (exceeds 4 allowed).
    Open

    func (w *walker) walk(path string, i1, i2 os.FileInfo) (err error) {
    // Register these nodes with the return trees, unless we're still at the
    // (already-created) roots:
    if path != "/" {
        if err := walkchunk(path, i1, w.dir1, w.root1); err != nil {
    Severity: Major
    Found in pkg/archive/changes_linux.go - About 55 mins to fix

      There are no issues that match your filters.

      Category
      Status