Sign upLogin

dotcloud/docker

View on GitHub
Star
pkg/archive/diff.go

Summary

Maintainability
D
3 days
Test Coverage

Function UnpackLayer has a Cognitive Complexity of 117 (exceeds 20 allowed). Consider refactoring.
Open

func UnpackLayer(dest string, layer io.Reader, options *TarOptions) (size int64, err error) {
    tr := tar.NewReader(layer)
    trBuf := pools.BufioReader32KPool.Get(tr)
    defer pools.BufioReader32KPool.Put(trBuf)
Severity: Minor
Found in pkg/archive/diff.go - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function UnpackLayer has 135 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func UnpackLayer(dest string, layer io.Reader, options *TarOptions) (size int64, err error) {
    tr := tar.NewReader(layer)
    trBuf := pools.BufioReader32KPool.Get(tr)
    defer pools.BufioReader32KPool.Put(trBuf)
Severity: Major
Found in pkg/archive/diff.go - About 4 hrs to fix

    Function UnpackLayer has 20 return statements (exceeds 4 allowed).
    Open

    func UnpackLayer(dest string, layer io.Reader, options *TarOptions) (size int64, err error) {
    tr := tar.NewReader(layer)
    trBuf := pools.BufioReader32KPool.Get(tr)
    defer pools.BufioReader32KPool.Put(trBuf)
    Severity: Major
    Found in pkg/archive/diff.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                          if err := os.RemoveAll(path); err != nil {
                        return 0, err
                    }
      Severity: Major
      Found in pkg/archive/diff.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if os.IsNotExist(err) {
                            err = nil // parent was deleted
                        }
        Severity: Major
        Found in pkg/archive/diff.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if aufsTempdir, err = os.MkdirTemp(dest, "dockerplnk"); err != nil {
                        return 0, err
                    }
          Severity: Major
          Found in pkg/archive/diff.go - About 45 mins to fix

            There are no issues that match your filters.

            Category
            Status