Sign upLogin

dotcloud/docker

View on GitHub
Star
pkg/idtools/idtools_unix.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function mkdirAs has 8 return statements (exceeds 4 allowed).
Open

func mkdirAs(path string, mode os.FileMode, owner Identity, mkAll, chownExisting bool) error {
    path, err := filepath.Abs(path)
    if err != nil {
        return err
    }
Severity: Major
Found in pkg/idtools/idtools_unix.go - About 50 mins to fix

    Function mkdirAs has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func mkdirAs(path string, mode os.FileMode, owner Identity, mkAll, chownExisting bool) error {
    path, err := filepath.Abs(path)
    if err != nil {
        return err
    }
    Severity: Minor
    Found in pkg/idtools/idtools_unix.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func lookupSubGIDRanges(usr user.User) ([]IDMap, error) {
    rangeList, err := parseSubgid(strconv.Itoa(usr.Uid))
    if err != nil {
        return nil, err
    }
    Severity: Major
    Found in pkg/idtools/idtools_unix.go and 1 other location - About 1 hr to fix
    pkg/idtools/idtools_unix.go on lines 246..261

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 148.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func lookupSubUIDRanges(usr user.User) ([]IDMap, error) {
    rangeList, err := parseSubuid(strconv.Itoa(usr.Uid))
    if err != nil {
        return nil, err
    }
    Severity: Major
    Found in pkg/idtools/idtools_unix.go and 1 other location - About 1 hr to fix
    pkg/idtools/idtools_unix.go on lines 263..278

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 148.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func getentUser(name string) (user.User, error) {
    reader, err := callGetent("passwd", name)
    if err != nil {
        return user.User{}, err
    }
    Severity: Major
    Found in pkg/idtools/idtools_unix.go and 1 other location - About 1 hr to fix
    pkg/idtools/idtools_unix.go on lines 142..155

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 135.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func getentGroup(name string) (user.Group, error) {
    reader, err := callGetent("group", name)
    if err != nil {
        return user.Group{}, err
    }
    Severity: Major
    Found in pkg/idtools/idtools_unix.go and 1 other location - About 1 hr to fix
    pkg/idtools/idtools_unix.go on lines 103..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 135.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status