Sign upLogin

dotcloud/docker

View on GitHub
Star
pkg/tailfile/tailfile.go

Summary

Maintainability
A
1 hr
Test Coverage

Function NewTailReaderWithDelimiter has 6 return statements (exceeds 4 allowed).
Open

func NewTailReaderWithDelimiter(ctx context.Context, r SizeReaderAt, reqLines int, delimiter []byte) (*io.SectionReader, int, error) {
    if reqLines < 1 {
        return nil, 0, ErrNonPositiveLinesNumber
    }
    if len(delimiter) == 0 {
Severity: Major
Found in pkg/tailfile/tailfile.go - About 40 mins to fix

    Method scanner.Scan has 5 return statements (exceeds 4 allowed).
    Open

    func (s *scanner) Scan(ctx context.Context) bool {
    if s.err != nil {
        return false
    }
    Severity: Major
    Found in pkg/tailfile/tailfile.go - About 35 mins to fix

      Method scanner.Scan has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

      func (s *scanner) Scan(ctx context.Context) bool {
    if s.err != nil {
        return false
    }
      Severity: Minor
      Found in pkg/tailfile/tailfile.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status