Sign upLogin

dotcloud/docker

View on GitHub
Star
plugin/fetch_linux.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function withFetchProgress has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
Open

func withFetchProgress(cs content.Store, out progress.Output, ref reference.Named) images.HandlerFunc {
    return func(ctx context.Context, desc ocispec.Descriptor) ([]ocispec.Descriptor, error) {
        switch desc.MediaType {
        case ocispec.MediaTypeImageManifest, images.MediaTypeDockerSchema2Manifest:
            tn := reference.TagNameOnly(ref)
Severity: Minor
Found in plugin/fetch_linux.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function withFetchProgress has 74 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func withFetchProgress(cs content.Store, out progress.Output, ref reference.Named) images.HandlerFunc {
    return func(ctx context.Context, desc ocispec.Descriptor) ([]ocispec.Descriptor, error) {
        switch desc.MediaType {
        case ocispec.MediaTypeImageManifest, images.MediaTypeDockerSchema2Manifest:
            tn := reference.TagNameOnly(ref)
Severity: Minor
Found in plugin/fetch_linux.go - About 1 hr to fix

    Method Manager.fetch has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (pm *Manager) fetch(ctx context.Context, ref reference.Named, auth *registry.AuthConfig, out progress.Output, metaHeader http.Header, handlers ...images.Handler) (err error) {
    Severity: Minor
    Found in plugin/fetch_linux.go - About 45 mins to fix

      Method Manager.fetch has 5 return statements (exceeds 4 allowed).
      Open

      func (pm *Manager) fetch(ctx context.Context, ref reference.Named, auth *registry.AuthConfig, out progress.Output, metaHeader http.Header, handlers ...images.Handler) (err error) {
    // We need to make sure we have a domain on the reference
    withDomain, err := reference.ParseNormalizedNamed(ref.String())
    if err != nil {
        return errors.Wrap(err, "error parsing plugin image reference")
      Severity: Major
      Found in plugin/fetch_linux.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status