Sign upLogin

dotcloud/docker

View on GitHub
Star
plugin/v2/plugin.go

Summary

Maintainability
C
1 day
Test Coverage

Method Plugin.Set has a Cognitive Complexity of 51 (exceeds 20 allowed). Consider refactoring.
Open

func (p *Plugin) Set(args []string) error {
    p.mu.Lock()
    defer p.mu.Unlock()

    if p.PluginObj.Enabled {
Severity: Minor
Found in plugin/v2/plugin.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Plugin has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

type Plugin struct {
    mu        sync.RWMutex
    PluginObj types.Plugin `json:"plugin"` // todo: embed struct
    pClient   *plugins.Client
    refCount  int
Severity: Minor
Found in plugin/v2/plugin.go - About 2 hrs to fix

    Method Plugin.Set has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (p *Plugin) Set(args []string) error {
    p.mu.Lock()
    defer p.mu.Unlock()

    if p.PluginObj.Enabled {
    Severity: Minor
    Found in plugin/v2/plugin.go - About 1 hr to fix

      Method Plugin.Set has 14 return statements (exceeds 4 allowed).
      Open

      func (p *Plugin) Set(args []string) error {
    p.mu.Lock()
    defer p.mu.Unlock()

    if p.PluginObj.Enabled {
      Severity: Major
      Found in plugin/v2/plugin.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for _, mount := range p.PluginObj.Config.Mounts {
            // found the mount in the config
            if mount.Name == s.name {
                // is it settable ?
                if ok, err := s.isSettable(allowedSettableFieldsMounts, mount.Settable); err != nil {
        Severity: Minor
        Found in plugin/v2/plugin.go and 1 other location - About 55 mins to fix
        plugin/v2/plugin.go on lines 169..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 124.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for _, device := range p.PluginObj.Config.Linux.Devices {
            // found the device in the config
            if device.Name == s.name {
                // is it settable ?
                if ok, err := s.isSettable(allowedSettableFieldsDevices, device.Settable); err != nil {
        Severity: Minor
        Found in plugin/v2/plugin.go and 1 other location - About 55 mins to fix
        plugin/v2/plugin.go on lines 149..166

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 124.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status