Sign upLogin

dotcloud/docker

View on GitHub
Star
profiles/seccomp/default_linux.go

Summary

Maintainability
F
5 days
Test Coverage

Function DefaultProfile has 781 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func DefaultProfile() *Seccomp {
    nosys := uint(unix.ENOSYS)
    syscalls := []*Syscall{
        {
            LinuxSyscall: specs.LinuxSyscall{
Severity: Major
Found in profiles/seccomp/default_linux.go - About 3 days to fix

    File default_linux.go has 824 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package seccomp // import "github.com/docker/docker/profiles/seccomp"

import (
    "github.com/opencontainers/runtime-spec/specs-go"
    "golang.org/x/sys/unix"
    Severity: Major
    Found in profiles/seccomp/default_linux.go - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  LinuxSyscall: specs.LinuxSyscall{
                Names: []string{
                    "clone",
                },
                Action: specs.ActAllow,
      Severity: Minor
      Found in profiles/seccomp/default_linux.go and 1 other location - About 55 mins to fix
      profiles/seccomp/default_linux.go on lines 638..651

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  LinuxSyscall: specs.LinuxSyscall{
                Names: []string{
                    "clone",
                },
                Action: specs.ActAllow,
      Severity: Minor
      Found in profiles/seccomp/default_linux.go and 1 other location - About 55 mins to fix
      profiles/seccomp/default_linux.go on lines 618..631

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status