Sign upLogin

dotcloud/docker

View on GitHub
Star
registry/config.go

Summary

Maintainability
A
1 hr
Test Coverage

Function ValidateMirror has 5 return statements (exceeds 4 allowed).
Open

func ValidateMirror(val string) (string, error) {
    uri, err := url.Parse(val)
    if err != nil {
        return "", invalidParamWrapf(err, "invalid mirror: %q is not a valid URI", val)
    }
Severity: Major
Found in registry/config.go - About 35 mins to fix

    Method serviceConfig.loadInsecureRegistries has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
    Open

    func (config *serviceConfig) loadInsecureRegistries(registries []string) error {
    // Localhost is by default considered as an insecure registry. This is a
    // stop-gap for people who are running a private registry on localhost.
    registries = append(registries, "::1/128", "127.0.0.0/8")
    Severity: Minor
    Found in registry/config.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status