Sign upLogin

dotcloud/docker

View on GitHub
Star
testutil/fixtures/load/frozen.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function FrozenImagesLinux has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func FrozenImagesLinux(ctx context.Context, client client.APIClient, images ...string) error {
    ctx, span := otel.Tracer("").Start(ctx, "LoadFrozenImages")
    defer span.End()

    var loadImages []struct{ srcName, destName string }
Severity: Minor
Found in testutil/fixtures/load/frozen.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readFrozenImageList has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func readFrozenImageList(ctx context.Context, dockerfilePath string, images []string) (map[string]string, error) {
    f, err := os.Open(dockerfilePath)
    if err != nil {
        return nil, errors.Wrap(err, "error reading dockerfile")
    }
Severity: Minor
Found in testutil/fixtures/load/frozen.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function FrozenImagesLinux has 6 return statements (exceeds 4 allowed).
Open

func FrozenImagesLinux(ctx context.Context, client client.APIClient, images ...string) error {
    ctx, span := otel.Tracer("").Start(ctx, "LoadFrozenImages")
    defer span.End()

    var loadImages []struct{ srcName, destName string }
Severity: Major
Found in testutil/fixtures/load/frozen.go - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status