Sign upLogin

dotcloud/docker

View on GitHub
Star
volume/service/restore.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method VolumeStore.restore has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

func (s *VolumeStore) restore() {
    var ls []volumeMetadata
    s.db.View(func(tx *bolt.Tx) error {
        ls = listMeta(tx)
        return nil
Severity: Minor
Found in volume/service/restore.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method VolumeStore.restore has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *VolumeStore) restore() {
    var ls []volumeMetadata
    s.db.View(func(tx *bolt.Tx) error {
        ls = listMeta(tx)
        return nil
Severity: Minor
Found in volume/service/restore.go - About 1 hr to fix

    Method VolumeStore.restore has 5 return statements (exceeds 4 allowed).
    Open

    func (s *VolumeStore) restore() {
    var ls []volumeMetadata
    s.db.View(func(tx *bolt.Tx) error {
        ls = listMeta(tx)
        return nil
    Severity: Major
    Found in volume/service/restore.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status