Sign upLogin

dothiv/DothivContentfulBundle

View on GitHub
Star

Showing 28 of 28 total issues

Function webhookAction has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function webhookAction(Request $request)
    {
        $topic = $request->headers->get('X-Contentful-Topic');
        if (!$topic) {
            $this->log('Missing X-Contentful-Topic header!');
Severity: Minor
Found in Controller/WebhookController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function cache(ContentfulAsset $asset)
    {
        if (!isset($asset->file)) {
            $this->log('Asset %s has no file.', $asset);
            return;
Severity: Minor
Found in Adapter/FilesystemAssetAdapter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addSize has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function addSize($label, $width, $height, $thumbnail, $exact, $fillbg)
Severity: Minor
Found in Output/ImageAssetScaler.php - About 45 mins to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($label, $width, $height, $thumbnail, $exact, $fillbg)
    Severity: Minor
    Found in Service/ImageScaler/ThumbnailConfiguration.php - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

                  return null;
      Severity: Major
      Found in Twig/Extension/ContentfulTwigExtension.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return Option::fromValue($newValue);
        Severity: Major
        Found in Output/ViewBuilder.php - About 30 mins to fix

          Function onViewCreate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function onViewCreate(ContentfulViewEvent $event)
    {
        $view = $event->getView();
        if ($view->cfMeta['contentType'] != $this->contentType) return;
        $field = $this->field;
          Severity: Minor
          Found in Listener/ViewCreateImageListener.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function onContentTypesSync has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function onContentTypesSync(ContentfulContentTypesEvent $event)
    {
        $contentTypesToSpaceId = new ArrayCollection();
        foreach ($event->getContentTypes() as $contentType) {
            if (!$contentTypesToSpaceId->containsKey($contentType->getSpaceId())) {
          Severity: Minor
          Found in Listener/SyncContentType.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language