downtowngr/mantle

View on GitHub

Showing 3 of 3 total issues

Method feature_collection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def feature_collection
    features = @db[:stops].all.map do |stop|
      stop_point = @coder.geo_factory.point(stop[:stop_lon], stop[:stop_lat])
      next unless @bb.contains?(stop_point)

Severity: Minor
Found in tasks/generate_transit_stops.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method photos has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def photos
    photos = []
    number = [5, photo_array.count].min
    count  = 0

Severity: Minor
Found in lib/instagram_media.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hour12 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def hour12(time)
    # Converts 24-hour string into 12-hour string.

    time.gsub!(/^\+/, "")

Severity: Minor
Found in includes/attribute_helpers.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language