Sign upLogin

dpla/heidrun

View on GitHub
Star
app/harvesters/ia_harvester.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method enumerate_records has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def enumerate_records(identifiers)
    batch = []
    # get meta.xml for each identifier in the batch
    identifiers.each do |id|
      meta_uri = "#{DOWNLOAD_BASE_URI}/#{id}/#{id}_meta.xml"
Severity: Minor
Found in app/harvesters/ia_harvester.rb - About 1 hr to fix

    Method record_ids has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def record_ids
    Enumerator.new do |en|
      cursor = nil
      loop do
        cursor_param = cursor ? "&cursor=#{cursor}" : ''
    Severity: Minor
    Found in app/harvesters/ia_harvester.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method enumerate_records has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def enumerate_records(identifiers)
    batch = []
    # get meta.xml for each identifier in the batch
    identifiers.each do |id|
      meta_uri = "#{DOWNLOAD_BASE_URI}/#{id}/#{id}_meta.xml"
    Severity: Minor
    Found in app/harvesters/ia_harvester.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status