Sign upLogin

dpn-admin/dpn-server

View on GitHub
Star
app/jobs/client/repl/cancel_job.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method cancel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def cancel(remote_client, get_query, cancel_query)
        remote_client.execute get_query do |response|
          raise RuntimeError, response.body unless response.success?
          return if response.body[:cancelled]
        end
Severity: Minor
Found in app/jobs/client/repl/cancel_job.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method normalize_args has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def normalize_args(record, namespace, get_query_type, cancel_query_type, adapter_class)
Severity: Minor
Found in app/jobs/client/repl/cancel_job.rb - About 35 mins to fix

Method perform has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def perform(record, namespace, get_query_type, cancel_query_type, adapter_class)
Severity: Minor
Found in app/jobs/client/repl/cancel_job.rb - About 35 mins to fix

There are no issues that match your filters.

Category
Status