Sign upLogin

dpree/eq

View on GitHub
Star

Showing 5 of 5 total issues

Method reserve has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def reserve
      db.transaction do
        if job = waiting.order(:id).last # asc
          job[:started_working_at] = Time.now
          update_job!(job)
Severity: Minor
Found in lib/eq-queueing/backends/sequel.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method push has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def push eq_job
      job = {queue: eq_job.queue}
      job[:payload] = Marshal.dump(eq_job.payload).to_sequel_blob unless eq_job.payload.nil?
      if eq_job.unique? && jobs.where(job).count > 0
        false
Severity: Minor
Found in lib/eq-queueing/backends/sequel.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_jobs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def process_jobs
      sleep EQ.config.worker_delay

      # TODO check if this is really what we want here, does it stop gracefully?
      while Celluloid::Actor.current.alive?
Severity: Minor
Found in lib/eq-working/worker.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method manage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def manage action, just=nil
    what = just ? just.to_s : "queue work schedul"
    EQ::Queueing.send(action) if what =~ /queue/ && queueing_loaded?
    EQ::Working.send(action) if what =~ /work/ && working_loaded?
    EQ::Scheduling.send(action) if what =~ /schedu/ && working_loaded?
Severity: Minor
Found in lib/eq.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exists? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def exists? job
        db.each do |k,v|
          if k.include?(QUEUE) && v == job.queue
            if find_payload(job_id_from_key(k)) == job.payload
              return true
Severity: Minor
Found in lib/eq-queueing/backends/leveldb.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language