Sign upLogin

dragonchain/dragonchain-sdk-go

View on GitHub
Star
credentials.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function NewCredentials has 6 return statements (exceeds 4 allowed).
Open

func NewCredentials(dcID, authKey, authKeyID, algorithm string) (*Credentials, error) {
    var err error
    var hashFunc func() hash.Hash

    switch algorithm {
Severity: Major
Found in credentials.go - About 40 mins to fix

    Function getAuthKeyID has 5 return statements (exceeds 4 allowed).
    Open

    func getAuthKeyID(ID string) (string, error) {
    authKeyID := os.Getenv(EnvKeyIDName)
    if len(authKeyID) > 0 {
        return authKeyID, nil
    }
    Severity: Major
    Found in credentials.go - About 35 mins to fix

      Function getAuthKey has 5 return statements (exceeds 4 allowed).
      Open

      func getAuthKey(dcID string) (string, error) {
    authKey := os.Getenv(EnvKeyName)
    if len(authKey) > 0 {
        return authKey, nil
    }
      Severity: Major
      Found in credentials.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func getAuthKey(dcID string) (string, error) {
    authKey := os.Getenv(EnvKeyName)
    if len(authKey) > 0 {
        return authKey, nil
    }
        Severity: Minor
        Found in credentials.go and 1 other location - About 55 mins to fix
        credentials.go on lines 156..173

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func getAuthKeyID(ID string) (string, error) {
    authKeyID := os.Getenv(EnvKeyIDName)
    if len(authKeyID) > 0 {
        return authKeyID, nil
    }
        Severity: Minor
        Found in credentials.go and 1 other location - About 55 mins to fix
        credentials.go on lines 137..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status