Sign upLogin

dragonchain/dragonchain

View on GitHub
Star
dragonchain/lib/matchmaking.py

Summary

Maintainability
B
6 hrs
Test Coverage
F
24%

File matchmaking.py has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2020 Dragonchain, Inc.
# Licensed under the Apache License, Version 2.0 (the "Apache License")
# with the following modification; you may not use this file except in
# compliance with the Apache License and the following modification to it:
# Section 6. Trademarks. is deleted and replaced with:
Severity: Minor
Found in dragonchain/lib/matchmaking.py - About 3 hrs to fix

    Function make_matchmaking_request has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    def make_matchmaking_request(
    http_verb: str, path: str, json_content: dict = None, retry: bool = True, authenticated: bool = True
) -> requests.Response:
    """Make an authenticated request to matchmaking and return the response
    Args:
    Severity: Minor
    Found in dragonchain/lib/matchmaking.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_receipt has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def add_receipt(l1_block_id: str, level: int, dc_id: str, block_id: str, proof: str) -> None:
    Severity: Minor
    Found in dragonchain/lib/matchmaking.py - About 35 mins to fix

      Function make_matchmaking_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def make_matchmaking_request(
      Severity: Minor
      Found in dragonchain/lib/matchmaking.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status