Sign upLogin

dragosboca/devinstall

View on GitHub
Star

Showing 9 of 9 total issues

Method method_missing has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def method_missing (method, *args)
      raise UnknownKeyError, "Undefined section '#{method}'" unless method_defined? method
      key  = (args.shift or {})
      rest = (Hash === key) ? key : (args.shift or {})
      pkg  = rest[:pkg]
Severity: Minor
Found in lib/devinstall/settings.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

command :test do |c|
  c.action do |args, options|
    config=Devinstall::Settings.instance
    load_defaults unless options.config
    type = options.type ? options.type.to_sym : config.defaults(:type)
Severity: Major
Found in lib/devinstall/cli.rb and 1 other location - About 1 hr to fix
lib/devinstall/cli.rb on lines 30..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

command :build do |c|
  c.action do |args, options|
    config=Devinstall::Settings.instance
    load_defaults unless options.config
    type = options.type ? options.type.to_sym : config.defaults(:type)
Severity: Major
Found in lib/devinstall/cli.rb and 1 other location - About 1 hr to fix
lib/devinstall/cli.rb on lines 59..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method load! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def load! (filename)
       if FILES.include? filename
          true
       else
          FILES << filename
Severity: Minor
Found in lib/devinstall/settings.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method global_or_local has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def global_or_local(section, key, pkg, type, env)
Severity: Minor
Found in lib/devinstall/settings.rb - About 35 mins to fix

    Method key_defined? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def key_defined?(method, key)
      method, key = (method.to_sym rescue method), (key.to_sym rescue key)
      method_defined? method and
          (MDEFS[method].include? key rescue false) or
          PROVIDERS.inject(false) { |res, (_, v)| res or (v[method].include? key rescue false) }
    Severity: Minor
    Found in lib/devinstall/settings.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def put_file(file)
      config = Settings.instance
      local  = File.expand_path config.local(:temp, pkg: @pkg, type: @type, env: @env)
      cfg    = config.send(@action, pkg: @pkg, type: @type, env: @env)
      upload_file(cfg, file, local)
    Severity: Minor
    Found in lib/devinstall/provider.rb and 1 other location - About 30 mins to fix
    lib/devinstall/provider.rb on lines 31..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def get_file(file)
      config = Settings.instance
      local  = File.expand_path config.local(:temp, pkg: @pkg, type: @type, env: @env)
      cfg    = config.send(@action, pkg: @pkg, type: @type, env: @env)
      download_file(cfg, file, local)
    Severity: Minor
    Found in lib/devinstall/provider.rb and 1 other location - About 30 mins to fix
    lib/devinstall/provider.rb on lines 38..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method key_chain has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def key_chain(*keys)
      res=SETTINGS
      keys.each do |key|
        next if key.nil?
        return nil unless res.has_key? key.to_sym
    Severity: Minor
    Found in lib/devinstall/settings.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language